Skip to content

Pre commit hook#85

Merged
neersighted merged 1 commit into
python-poetry:mainfrom
dimbleby:pre-commit-hook
Sep 6, 2022
Merged

Pre commit hook#85
neersighted merged 1 commit into
python-poetry:mainfrom
dimbleby:pre-commit-hook

Conversation

@dimbleby

@dimbleby dimbleby commented Jul 9, 2022

Copy link
Copy Markdown
Contributor

python-poetry/poetry#5980 removed this from poetry, here's a replacement

@sonarqubecloud

sonarqubecloud Bot commented Jul 9, 2022

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@dimbleby

dimbleby commented Aug 13, 2022

Copy link
Copy Markdown
Contributor Author

NB whether or not we remove the circular dependency per python-poetry/poetry#5980, it makes sense for this repository to be the one that provides the precommit hook

@neersighted

Copy link
Copy Markdown
Member

I wonder if it's productive to add a stub hook upstream -- something like echo "This hook has moved! See <issue link> to migrate." && exit 1

@neersighted neersighted merged commit d186c95 into python-poetry:main Sep 6, 2022
@dimbleby dimbleby deleted the pre-commit-hook branch September 7, 2022 07:57
@radoering radoering mentioned this pull request Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants