Skip to content

fix: Cast verbosity comparison to Literal type #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
caffeine-addictt merged 1 commit into from
May 25, 2024
Merged

fix: Cast verbosity comparison to Literal type #84

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/thread/utils/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
from typing import Any, Callable, Literal, Union
from typing import Any, Callable, Literal, Union, cast

_Verbosity_Num = Literal[0, 1, 2]
_Verbosity_Enum = Literal['quiet', 'normal', 'verbose']
Expand Down Expand Up @@ -79,6 +79,7 @@ def _compare(
return operator(self.level_number, other)
if isinstance(other, str):
if Verbosity.is_valid_level(other):
other = cast(_Verbosity_Enum, other)
return operator(self.level_number, VerbosityMapping[other])
return operator(self.level_string, other)
raise ValueError('Cannot compare Verbosity with other types')
Expand Down