Skip to content

Add 106, don't fancy import trio#11

Closed
jakkdl wants to merge 0 commit into
python-trio:mainfrom
jakkdl:trio106
Closed

Add 106, don't fancy import trio#11
jakkdl wants to merge 0 commit into
python-trio:mainfrom
jakkdl:trio106

Conversation

@jakkdl

@jakkdl jakkdl commented Jul 28, 2022

Copy link
Copy Markdown
Member

Uh, I'll just let you add this one to the changelog&readme, and increment version, with there being three simultaneous open pull requests.

Comment thread tests/trio106.py
Comment thread flake8_trio.py
@jakkdl

jakkdl commented Jul 28, 2022

Copy link
Copy Markdown
Member Author

While on it I resolved the above

@Zac-HD Zac-HD mentioned this pull request Jul 28, 2022
12 tasks
@Zac-HD Zac-HD closed this Jul 29, 2022
@Zac-HD

Zac-HD commented Jul 29, 2022

Copy link
Copy Markdown
Member

OK, apparently pushing commits marks the PR as closed rather than merged 😕

It's merged to me though!

@jakkdl

jakkdl commented Jul 29, 2022

Copy link
Copy Markdown
Member Author

Yeah that's some funky UI. It's marked as Closed, but it also says Pull request successfully merged and closed. But no matter

It looks like TRIO106 is missing from the readme though

@jakkdl

jakkdl commented Jul 29, 2022

Copy link
Copy Markdown
Member Author

It could be worth adding a test that checks that each error message is mentioned in all four of the readme, changelog, plugin file and test file.

@Zac-HD

Zac-HD commented Jul 29, 2022

Copy link
Copy Markdown
Member

Sounds good, go for it!

@jakkdl

jakkdl commented Jul 29, 2022

Copy link
Copy Markdown
Member Author

Opened an issue 👍

@jakkdl jakkdl deleted the trio106 branch December 9, 2022 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants