Skip to content

Meta-tests#14

Merged
Zac-HD merged 1 commit into
python-trio:mainfrom
jakkdl:meta-tests
Jul 29, 2022
Merged

Meta-tests#14
Zac-HD merged 1 commit into
python-trio:mainfrom
jakkdl:meta-tests

Conversation

@jakkdl

@jakkdl jakkdl commented Jul 29, 2022

Copy link
Copy Markdown
Member

Fixes #13

Also found what I think is a bug in TRIO100, and added TRIO106 to README.md

@Zac-HD Zac-HD left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice ✅

Quick style note, if you're comfortable with pytest-style test functions I'm just as happy to use those as unittest classes.

@Zac-HD Zac-HD merged commit 18a0d29 into python-trio:main Jul 29, 2022
@jakkdl

jakkdl commented Jul 30, 2022

Copy link
Copy Markdown
Member Author

I haven't used either extensively enough to have too much of an opinion - but I needed access to a msg parameter to give more info and the first place I looked that had it was unittest.

Even better would be to have multiple different tests generated for each file, instead of it quitting on the first file/test pair that fails, but didn't bother spending time on figuring out how to do that.

@Zac-HD

Zac-HD commented Jul 30, 2022

Copy link
Copy Markdown
Member

assert condition, "message" is the pytest idiom fyi 🙂

Agree that it's not worth extending further though!

@jakkdl

jakkdl commented Jul 30, 2022

Copy link
Copy Markdown
Member Author

Thank you, good to know!

@jakkdl jakkdl deleted the meta-tests branch December 9, 2022 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

meta-tests

2 participants