Use a longer sleep in test_run::test_timekeeping#1173
Merged
Conversation
This test has been the source of a few intermittent failures recently: python-trio#200 (comment) Not really clear if this will solve the problem, but it's worth a try.
Member
Author
|
Test failure should be fixed by #1172 |
Codecov Report
@@ Coverage Diff @@
## master #1173 +/- ##
=======================================
Coverage 99.55% 99.55%
=======================================
Files 106 106
Lines 12751 12751
Branches 978 978
=======================================
Hits 12694 12694
Misses 36 36
Partials 21 21
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #1173 +/- ##
=======================================
Coverage 99.55% 99.55%
=======================================
Files 106 106
Lines 12751 12751
Branches 978 978
=======================================
Hits 12694 12694
Misses 36 36
Partials 21 21
|
belm0
reviewed
Aug 2, 2019
belm0
left a comment
belm0
left a comment
Member
There was a problem hiding this comment.
I think it's futile to have wall clock dependent tests running on free virtualized computers.
Perhaps just change the test to >=, and rely on precise mocking to confirm that cancel scope honors deadline correctly (likely already covered).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test has been the source of a few intermittent failures recently:
#200 (comment)
Not really clear if this will solve the problem, but it's worth a try.