Skip to content

Fixed unhelpful error message in from_thread_run functions. #1513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oremanj merged 16 commits into from
May 21, 2020
Merged

Fixed unhelpful error message in from_thread_run functions. #1513

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
96cdeb2
Added helpful error message in the case the user passed incorrect typ…
May 12, 2020
015b220
Extracted "coroutine or TypeError" logic from Runner.spawn_impl, move…
May 13, 2020
126f7f4
Added sync check
May 13, 2020
417ba5b
Ran code formatter and added comments.
May 13, 2020
dc06cad
Added coroutine_or_error test.
May 13, 2020
dc1e5b8
Added TypeError tests to from_thread_run and from_thread_run_sync
May 13, 2020
5e4145d
Moved comprehensive test of callable from test_run.py to test_util.py
May 13, 2020
c74a829
Added error message check
May 14, 2020
ad27338
Marked some function stubs with #pragma no cover
May 14, 2020
57c1080
Fixed comment on spawn_impl. Moved ignore_coroutine_never_awaited_war…
May 15, 2020
f4c11e9
Fixed/added some comments. Removed unnecessary ignore_coroutine_never…
May 16, 2020
28b08d1
Fixed a comment and other formatting issues.
May 18, 2020
0f809d0
Remove another extra blank line
oremanj May 20, 2020
7a71a85
Remove a couple more of the extra added blank lines
oremanj May 20, 2020
7de4c84
Added newsfragment
May 20, 2020
f77c200
Update newsfragments/1244.bugfix.rst
May 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions newsfragments/1244.bugfix.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Added helpful error message in the case the user passed incorrect type of function to "from_thread_run" & "from_thread_run_sync" functions.