Added helpful error message if an async function is passed to trio.to_thread_run_sync#1575
Merged
oremanj merged 2 commits intopython-trio:masterfrom Jun 9, 2020
Merged
Added helpful error message if an async function is passed to trio.to_thread_run_sync#1575oremanj merged 2 commits intopython-trio:masterfrom
oremanj merged 2 commits intopython-trio:masterfrom
Conversation
…to_thread_run_sync
pquentin
approved these changes
Jun 9, 2020
Member
pquentin
left a comment
pquentin
left a comment
There was a problem hiding this comment.
Thanks! Two minor things left.
Codecov Report
@@ Coverage Diff @@
## master #1575 +/- ##
==========================================
- Coverage 99.69% 99.69% -0.01%
==========================================
Files 111 109 -2
Lines 13866 13817 -49
Branches 1059 1056 -3
==========================================
- Hits 13824 13775 -49
Misses 27 27
Partials 15 15
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This functionality was previously added to the
trio.from_threadfunctions in #1513Closes #1573