Skip to content

Add Alpine to CI#2933

Merged
jakkdl merged 8 commits into
python-trio:masterfrom
A5rocks:ci-in-alpine
Jan 30, 2024
Merged

Add Alpine to CI#2933
jakkdl merged 8 commits into
python-trio:masterfrom
A5rocks:ci-in-alpine

Conversation

@A5rocks

@A5rocks A5rocks commented Jan 22, 2024

Copy link
Copy Markdown
Contributor

Ref: #2885

@A5rocks A5rocks mentioned this pull request Jan 22, 2024
17 tasks
@codecov

codecov Bot commented Jan 22, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7cb15ea) 99.64% compared to head (b5a8e1c) 99.64%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2933   +/-   ##
=======================================
  Coverage   99.64%   99.64%           
=======================================
  Files         116      116           
  Lines       17506    17506           
  Branches     3148     3148           
=======================================
  Hits        17444    17444           
  Misses         43       43           
  Partials       19       19           
Files Coverage Δ
src/trio/_tests/test_socket.py 100.00% <100.00%> (ø)

@jakkdl jakkdl left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skimmed the test logs, and IPv6 tests are being skipped

  SKIPPED [1] ../.venv/lib/python3.11/site-packages/trio/_tests/test_dtls.py:87: need IPv6

probably not a big deal, but would be nice if it was possible to enable ipv6.

So other than the minor stuff, looks great!

Comment thread src/trio/_tests/test_socket.py Outdated
Comment thread .github/workflows/ci.yml Outdated
@A5rocks

A5rocks commented Jan 30, 2024

Copy link
Copy Markdown
Contributor Author

Doesn't look like we can do IPv6. Making the socket works, but binding fails. It seems that this is a docker thing and that we'd need to configure the docker daemon? I found this stackoverflow post but it has no answers: https://stackoverflow.com/questions/75205327/configuring-docker-daemon-for-github-actions

Edit: also I removed musl-dev because #2939 should make that dependency not required.

@jakkdl

jakkdl commented Jan 30, 2024

Copy link
Copy Markdown
Member

Doesn't look like we can do IPv6. Making the socket works, but binding fails. It seems that this is a docker thing and that we'd need to configure the docker daemon? I found this stackoverflow post but it has no answers: https://stackoverflow.com/questions/75205327/configuring-docker-daemon-for-github-actions

Seems quite doable in theory then, but not worth the effort.

@jakkdl jakkdl merged commit ee209bf into python-trio:master Jan 30, 2024
@A5rocks A5rocks deleted the ci-in-alpine branch August 2, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants