Skip to content

Add Python 3.11 and 3.12 to Windows and MacOS matrices#3017

Merged
jakkdl merged 5 commits into
python-trio:masterfrom
A5rocks:standardize-windows-python
Jun 17, 2024
Merged

Add Python 3.11 and 3.12 to Windows and MacOS matrices#3017
jakkdl merged 5 commits into
python-trio:masterfrom
A5rocks:standardize-windows-python

Conversation

@A5rocks

@A5rocks A5rocks commented Jun 12, 2024

Copy link
Copy Markdown
Contributor

Part of: #2885

@A5rocks A5rocks mentioned this pull request Jun 12, 2024
17 tasks
@codecov

codecov Bot commented Jun 12, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.63%. Comparing base (451393a) to head (b06b544).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3017   +/-   ##
=======================================
  Coverage   99.63%   99.63%           
=======================================
  Files         120      120           
  Lines       17863    17863           
  Branches     3217     3217           
=======================================
  Hits        17798    17798           
  Misses         46       46           
  Partials       19       19           
Files with missing lines Coverage Δ
src/trio/socket.py 100.00% <ø> (ø)

@A5rocks A5rocks changed the title Add Python 3.11 and 3.12 to Windows CI Add Python 3.11 and 3.12 to Windows and MacOS matrices Jun 12, 2024
@A5rocks A5rocks closed this Jun 12, 2024
@A5rocks A5rocks deleted the standardize-windows-python branch June 12, 2024 14:47
@A5rocks

A5rocks commented Jun 12, 2024

Copy link
Copy Markdown
Contributor Author

Oh, turns out the github branch rename feature doesn't work. Oh well

@A5rocks A5rocks restored the standardize-windows-python branch June 12, 2024 14:48
@A5rocks A5rocks reopened this Jun 12, 2024
@A5rocks

A5rocks commented Jun 12, 2024

Copy link
Copy Markdown
Contributor Author

pre-commit.ci autofix

@CoolCat467 CoolCat467 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, simple enough

@jakkdl

jakkdl commented Jun 13, 2024

Copy link
Copy Markdown
Member

Huh, did we just forget to add these when adding 3.11/3.12 - or was something broken that now works? Not that it matters, good stuff.

@A5rocks

A5rocks commented Jun 14, 2024

Copy link
Copy Markdown
Contributor Author

It looks like I added 3.12 at least and while I can't remember exactly, I'm pretty sure I just forgot to add it to Windows/MacOS (because step 1 was adding 3.12-dev which we handle using a PPA, then step 2 (where I forgot) is just removing -dev)

@jakkdl jakkdl enabled auto-merge (squash) June 17, 2024 09:13
@jakkdl jakkdl merged commit 53ff38a into python-trio:master Jun 17, 2024
@A5rocks A5rocks deleted the standardize-windows-python branch August 2, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants