Skip to content

Configure coveragepy to separate importables&pths #3367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
webknjaz merged 1 commit into from
Dec 6, 2025
Merged

Configure coveragepy to separate importables&pths #3367

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,6 +293,10 @@ skip_covered = false

[tool.coverage.paths]
source = ["src", "**/site-packages"]
attrs-plugin = [
"tests/_trio_check_attrs_aliases.py",
"_trio_check_attrs_aliases.py",

@A5rocks A5rocks Dec 6, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, why this? I guess this is necessary to merge the importable with the file under tests/?

@webknjaz webknjaz Dec 6, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, I took wild a guess after you said that it's "installed" separately that this might've been something that you thought wasn't working in the past. I realized it's not installed but imported through an absolute path due to PYTHONPATH being set. And so I figured it would likely confuse the path mapper so I added an explicit one.
I haven't actually tested it locally even, just wanted to see what the PR would produce. Maybe it'd work even w/o this.

@webknjaz webknjaz Dec 6, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, looking at one of the codecov uploads (https://storage.googleapis.com/codecov-production/shelter/github/python-trio%3A%3A%3A%3Atrio/ffe7261e66a3f7af53e9671c9fc06e2342d3bda6/de0c6baf-a91a-4026-bc82-3382eb60fda8.txt?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=GOOG1EJOGFN2JQ4OCTGA2MU5AEIT7OT5Z7HTFOAN2SPG4NWSN2UJYOY5U6LZQ%2F20251206%2Fus-west2%2Fs3%2Faws4_request&X-Amz-Date=20251206T014925Z&X-Amz-Expires=30&X-Amz-SignedHeaders=host&X-Amz-Signature=4623e30cb5fbffcc5f205f54c40f2a8bb795d3b626d339e6763848ec2038497f), it contains <class name="_trio_check_attrs_aliases.py" filename="tests/_trio_check_attrs_aliases.py" complexity="0" line-rate="1" branch-rate="1"> so Codecov doesn't have a problem mapping it back to the repo.

]

[tool.coverage.run]
branch = true
Expand All @@ -311,7 +315,8 @@ omit = [
parallel = true
plugins = []
relative_files = true
source = ["trio", "tests/", "_trio_check_attrs_aliases"]
source = ["."]
source_pkgs = ["trio", "_trio_check_attrs_aliases"]

[tool.coverage.report]
precision = 1
Expand Down