Skip to content

Mark failing IPython multierror tests as xfail on 3.8#905

Merged
njsmith merged 1 commit into
python-trio:masterfrom
oremanj:disable-38-differently
Feb 5, 2019
Merged

Mark failing IPython multierror tests as xfail on 3.8#905
njsmith merged 1 commit into
python-trio:masterfrom
oremanj:disable-38-differently

Conversation

@oremanj

@oremanj oremanj commented Feb 5, 2019

Copy link
Copy Markdown
Member

Until ipython/ipython#11590 is fixed.

@codecov

codecov Bot commented Feb 5, 2019

Copy link
Copy Markdown

Codecov Report

Merging #905 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #905      +/-   ##
==========================================
+ Coverage   99.53%   99.53%   +<.01%     
==========================================
  Files         102      102              
  Lines       12411    12414       +3     
  Branches      916      916              
==========================================
+ Hits        12353    12356       +3     
  Misses         36       36              
  Partials       22       22
Impacted Files Coverage Δ
trio/_core/tests/test_multierror.py 100% <100%> (ø) ⬆️

@njsmith

njsmith commented Feb 5, 2019

Copy link
Copy Markdown
Member

Awesome, thanks!

@njsmith njsmith merged commit b2143c9 into python-trio:master Feb 5, 2019
@oremanj oremanj deleted the disable-38-differently branch February 5, 2019 18:09
@Carreau

Carreau commented Feb 5, 2019

Copy link
Copy Markdown
Contributor

See ipython/ipython#11593

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants