Skip to content

gh-104144: Skip scheduling a done callback if a TaskGroup task completes eagerly #104140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gvanrossum merged 6 commits into from
May 5, 2023
Merged

gh-104144: Skip scheduling a done callback if a TaskGroup task completes eagerly #104140

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5397cd9
gh-NNNN: Skip scheduling a done callback if a TaskGroup task complete…
itamaro May 3, 2023
8d6a77e
Add NEWS entry
itamaro May 3, 2023
a125c1f
Apply review feedback to NEWS entry
itamaro May 4, 2023
dae3e06
Merge branch 'main' into taskgroups-skip-done-callback
itamaro May 5, 2023
161d0f8
revert skipping _set_task_name if name is None; fix typo in comment
itamaro May 5, 2023
2b98bd9
Merge branch 'main' into taskgroups-skip-done-callback
itamaro May 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
revert skipping _set_task_name if name is None; fix typo in comment
  • Loading branch information
@itamaro
itamaro committed May 5, 2023
commit 161d0f8c6f0241bb20f887522659b1bc8700452d
5 changes: 2 additions & 3 deletions Lib/asyncio/taskgroups.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,9 +163,8 @@ def create_task(self, coro, *, name=None, context=None):
task = self._loop.create_task(coro)
else:
task = self._loop.create_task(coro, context=context)
if name is not None:
tasks._set_task_name(task, name)
# optimization: Immediately call the done callback is the task is
tasks._set_task_name(task, name)
# optimization: Immediately call the done callback if the task is
# already done (e.g. if the coro was able to complete eagerly),
# and skip scheduling a done callback
if task.done():
Expand Down