Skip to content

gh-107779: Check for the separator between date and time in datetime.datetime.fromisoformat#107791

Open
joaoe wants to merge 1 commit into
python:mainfrom
joaoe:gh107779_fromisoformat_separator
Open

gh-107779: Check for the separator between date and time in datetime.datetime.fromisoformat#107791
joaoe wants to merge 1 commit into
python:mainfrom
joaoe:gh107779_fromisoformat_separator

Conversation

@joaoe

@joaoe joaoe commented Aug 8, 2023

Copy link
Copy Markdown

@bedevere-bot

Copy link
Copy Markdown

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@ghost

ghost commented Aug 8, 2023

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.
CLA signed

@Eclips4

Eclips4 commented Aug 8, 2023

Copy link
Copy Markdown
Member

Thanks for trying to solve the problem!
Seems that datetime tests are falling, can you fix them?

@Eclips4 Eclips4 changed the title gh-107779: in datetime.fromisoformat, check the separator between date and time gh-107779: Check for the separator between date and time in datetime.datetime.fromisoformat Aug 8, 2023
@joaoe

joaoe commented Aug 9, 2023

Copy link
Copy Markdown
Author

@Eclips4 Hi. Yes, that's the plan, but there needs to be a bit more discussion in the main issue page. I push this to get a first run through the CI pipeline, so I see what needs to be done.

'2009-04-19T12:30:45.123456-05:00a', # Extra text
'2009-04-19T12:30:45.123-05:00a', # Extra text
'2009-04-19T12:30:45-05:00a', # Extra text
'2009-04-1912:30:45', # Missing date-time separator 1

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a valid ISO 8601 format...

By mutual agreement of the partners in information interchange, the character [T] may be omitted in
applications where there is no risk of confusing a date and time of day representation with others defined in this International Standard.

@github-actions

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Apr 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting review stale Stale PR or inactive for long period of time.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants