Skip to content

gh-108469: Update ast.unparse for unescaped quote support from PEP701 [3.12] #108553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pablogsal merged 11 commits into from
Sep 5, 2023
Merged

gh-108469: Update ast.unparse for unescaped quote support from PEP701 [3.12] #108553

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
5ee5d57
Add two tests for ast.unparse for unescaped quote support from PEP701
tonybaloney Aug 27, 2023
20b6455
Merge branch 'main' into unparse_pep701
tonybaloney Aug 27, 2023
d9bf98a
Merge branch 'main' into unparse_pep701
sunmy2019 Sep 2, 2023
cb043e0
unparse with new fstring syntax
sunmy2019 Sep 2, 2023
5ea8f4f
Add news
sunmy2019 Sep 2, 2023
e716e03
Merge branch 'main' into unparse_pep701
sunmy2019 Sep 2, 2023
1da1d4c
Update Lib/test/test_unparse.py
sunmy2019 Sep 2, 2023
43d177c
simplify things
sunmy2019 Sep 3, 2023
21229ce
reimplement quote selection logic
sunmy2019 Sep 3, 2023
9b1b5dd
Revert "reimplement quote selection logic"
sunmy2019 Sep 5, 2023
88394d1
clean up unnecessary parts
sunmy2019 Sep 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
simplify things
  • Loading branch information
@sunmy2019
sunmy2019 committed Sep 3, 2023
commit 43d177c32b3d8889f312e42ed0eba2c390ac41bf
5 changes: 1 addition & 4 deletions Lib/ast.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1254,10 +1254,7 @@ def visit_JoinedStr(self, node):
escape_special_whitespace=True,
)
elif "\n" in value:
if "'" in quote_types:
quote_types.remove("'")
if '"' in quote_types:
quote_types.remove('"')
quote_types = [q for q in quote_types if q in _MULTI_QUOTES]
new_fstring_parts.append(value)

value = "".join(new_fstring_parts)
Expand Down