gh-111806: Fix test_recursion in test_richcmp on WASI builds - #111830
Merged
Conversation
sobolevn
added
skip news
needs backport to 3.11
brettcannon
approved these changes
Nov 7, 2023
|
Thanks @sobolevn for the PR, and @brettcannon for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 7, 2023
pythonGH-111830) (cherry picked from commit f115a55) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
|
GH-111831 is a backport of this pull request to the 3.12 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 7, 2023
pythonGH-111830) (cherry picked from commit f115a55) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
|
GH-111832 is a backport of this pull request to the 3.11 branch. |
hugovk
pushed a commit
to hugovk/cpython
that referenced
this pull request
Nov 8, 2023
This was referenced Nov 8, 2023
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Next, I plan to do multiple issues at once, because it would be much easier to review.
They can be unified in logical bulks.
repr-based (next in my list):
test_repr_deepfromtest_userdicttriggers stack overflow protections for a debug build under WASI #111809test_repr_deepfromtest_userlisttriggers stack overflow protections for a debug build under WASI #111810test_recursive_reprfromtest_xml_etreetriggers stack overflow protections for a debug build under WASI #111811test_recursive_reprfromtest_iotriggers stack overflow protections in a debug build under WASI #111800testRecursiveReprfromtest_fileiotrigger stack overflow protections in a debug build under WASI #111799test_recursionfromtest_richcmptriggers stack overflow protections for a debug build under WASI #111806