Skip to content

[3.12] gh-109181: Fix refleak in tb_get_lineno() #111948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vstinner merged 1 commit into from
Nov 10, 2023
Merged

[3.12] gh-109181: Fix refleak in tb_get_lineno() #111948

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
gh-109181: Fix refleak in tb_get_lineno() 
PyFrame_GetCode() returns a strong reference.
  • Loading branch information
@vstinner
vstinner committed Nov 10, 2023
commit f2f63b7bdbb4fe3a8ba7b8dfdee2dbd9cc0968c3
5 changes: 4 additions & 1 deletion Python/traceback.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,10 @@ static int
tb_get_lineno(PyTracebackObject* tb) {
PyFrameObject* frame = tb->tb_frame;
assert(frame != NULL);
return PyCode_Addr2Line(PyFrame_GetCode(frame), tb->tb_lasti);
PyCodeObject *code = PyFrame_GetCode(frame);
int lineno = PyCode_Addr2Line(code, tb->tb_lasti);
Py_DECREF(code);
return lineno;
}

static PyObject *
Expand Down