Skip to content

gh-116785: Fix direct invocation of test_inspect#116787

Merged
sobolevn merged 1 commit into
python:mainfrom
sobolevn:issue-116785
Mar 14, 2024
Merged

gh-116785: Fix direct invocation of test_inspect#116787
sobolevn merged 1 commit into
python:mainfrom
sobolevn:issue-116785

Conversation

@sobolevn

@sobolevn sobolevn commented Mar 14, 2024 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

@hugovk @vstinner could you please take a look? :)

After this change:

» ./python.exe Lib/test/test_inspect/test_inspect.py
........................................................................................................................................................................................................................................................................................................
----------------------------------------------------------------------
Ran 296 tests in 0.542s

OK

@sobolevn sobolevn added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Mar 14, 2024
@sobolevn sobolevn requested review from hugovk and vstinner March 14, 2024 08:46
@bedevere-app bedevere-app Bot mentioned this pull request Mar 14, 2024
Closed
@bedevere-app bedevere-app Bot added the tests Tests in the Lib/test dir label Mar 14, 2024
vstinner
vstinner approved these changes Mar 14, 2024
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I confirm that currently, it fails, and with the change it works as expected.

@sobolevn sobolevn merged commit 66fb613 into python:main Mar 14, 2024
@miss-islington-app

miss-islington-app Bot commented Mar 14, 2024

Copy link
Copy Markdown

Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 14, 2024
@sobolevn @miss-islington
pythongh-116785: Fix direct invocation of test_inspect (pythonGH-11…
f198523 
…6787)

(cherry picked from commit 66fb613)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@bedevere-app

bedevere-app Bot commented Mar 14, 2024

Copy link
Copy Markdown

GH-116794 is a backport of this pull request to the 3.12 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 14, 2024
@sobolevn @miss-islington
pythongh-116785: Fix direct invocation of test_inspect (pythonGH-11…
a9b290a 
…6787)

(cherry picked from commit 66fb613)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Mar 14, 2024
@bedevere-app

bedevere-app Bot commented Mar 14, 2024

Copy link
Copy Markdown

GH-116795 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.11 only security fixes label Mar 14, 2024
@sobolevn

sobolevn commented Mar 14, 2024

Copy link
Copy Markdown
Member Author

Thanks for the quick reviews!

sobolevn added a commit that referenced this pull request Mar 14, 2024
@miss-islington @sobolevn
[3.12] gh-116785: Fix direct invocation of test_inspect (GH-116787) (…
c4a22ad 
…#116794)

gh-116785: Fix direct invocation of `test_inspect` (GH-116787)
(cherry picked from commit 66fb613)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
sobolevn added a commit that referenced this pull request Mar 14, 2024
@miss-islington @sobolevn
[3.11] gh-116785: Fix direct invocation of test_inspect (GH-116787) (…
c42e709 
…#116795)

gh-116785: Fix direct invocation of `test_inspect` (GH-116787)
(cherry picked from commit 66fb613)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
vstinner pushed a commit to vstinner/cpython that referenced this pull request Mar 20, 2024
@sobolevn @vstinner
pythongh-116785: Fix direct invocation of test_inspect (python#116787)
289a155
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 25, 2024
@sobolevn @adorilson
pythongh-116785: Fix direct invocation of test_inspect (python#116787)
cc826c7
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@sobolevn @diegorusso
pythongh-116785: Fix direct invocation of test_inspect (python#116787)
100c306
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes
@hugovk hugovk hugovk approved these changes

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sobolevn @vstinner @hugovk