bpo-35970: Add help flag to base64 util

[rkuska]

Probably a really unnecessary contribution but I failed today to print help message for base64 utility without an error:

 $ python3 -m base64 -help
option -h not recognized
usage: /usr/local/Cellar/python/3.7.2_1/Frameworks/Python.framework/Versions/3.7/lib/python3.7/base64.py [-d|-e|-u|-t] [file|-]
        -d, -u: decode
        -e: encode (default)
        -t: encode and decode string 'Aladdin:open sesame

So I felt like this is a ripple in time space continuum worth adjusting. I understand that this part of code is probably a long forgotten and therefore I will not be surprised if you decide to just close this PR.

https://bugs.python.org/issue35970

[the-knights-who-say-ni]

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

[remilapeyre]

Hi @rkuska, thanks for your contribution!

This is bug and all bugs are worth fixing!

There is some process to follow before submitting changes to Python, you can read about them at https://devguide.python.org/pullrequest/#quick-guide

You first need to create an account on https://bugs.python.org/ and open a new issue.

Your Pull Request will also need a test before being accepted.

You should also use https://blurb-it.herokuapp.com/ to add a news entry to your PR.

[rkuska]

I've created an issue and changed commit message and also edited PR title and lastly news entry was added. I will add also tests once I will get some ack about my fix - not sure if getopt shouldn't be replaced by argparse.

[remilapeyre]

I'm not sure getopt needs to be replaced, optparse has been deprecated but not getopt.

[remilapeyre]

I think you can convert this to an f-string

[remilapeyre]

Add Patch contributed by ...

[taleinat]

This certainly would be a nice improvement.

Please add two simple tests checking that the usage text is printed:

1. Running with -h
2. Running with an invalid parameter

(See TestMain in test_base64.py)

[bedevere-bot]

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

[csabella]

@rkuska, please address the code review for @taleinat. Thank you!

[taleinat]

Ping, @rkuska?

[ammaraskar]

Oops, I think I accidentally closed this while trying to update rkuska's branch. Let me update this work in a new PR.

[ammaraskar]

@taleinat would you mind giving #28774, a continuation of this PR a quick review?