Skip to content

gh-118507 : Refactor nt._path_is* #118755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zooba merged 44 commits into from
May 21, 2024
Merged

gh-118507 : Refactor nt._path_is* #118755

Changes from 1 commit
Commits
Show all changes
44 commits
Select commit Hold shift + click to select a range
ab76c06
Speedup `ntpath.exists`
nineteendo Apr 13, 2024
1c5350d
Update comment
nineteendo Apr 13, 2024
d7017ac
📜🤖 Added by blurb_it.
blurb-it[bot] Apr 13, 2024
2963338
Improve `nt_exists()`
nineteendo Apr 15, 2024
e833f04
Apply suggestions from code review
nineteendo Apr 15, 2024
d0493c2
Revert helper functions
nineteendo Apr 15, 2024
4403f4a
Update argument clinic
nineteendo Apr 15, 2024
7a9038f
Update 2024-04-13-11-30-09.gh-issue-117841.eW4w_y.rst
nineteendo Apr 22, 2024
a6ec86d
Merge branch 'main' into speedup-ntpath.lexists
nineteendo Apr 26, 2024
30603f0
Refactor `nt._path_is*`
nineteendo May 8, 2024
cd7c6d0
Add `nt._path_isjunction`
nineteendo May 8, 2024
168d299
Fix bug & further refactoring
nineteendo May 8, 2024
e00df4c
Fix attribute name
nineteendo May 8, 2024
b31a252
Add test for pipe
nineteendo May 8, 2024
59e1407
Skip unless `os.pipe` is available
nineteendo May 8, 2024
76acc0d
📜🤖 Added by blurb_it.
blurb-it[bot] May 8, 2024
2c8e464
Update Modules/posixmodule.c
nineteendo May 9, 2024
a8bc5f2
Update Modules/posixmodule.c
nineteendo May 9, 2024
55b6b80
Update Lib/test/test_ntpath.py
nineteendo May 9, 2024
61a62ce
Fix compilation errors
nineteendo May 9, 2024
ba79151
Update Modules/posixmodule.c
nineteendo May 9, 2024
5153413
Merge branch 'refactor-nt._path_is' into speedup-ntpath.lexists
nineteendo May 9, 2024
01568bb
Merge pull request #1 from nineteendo/speedup-ntpath.lexists
nineteendo May 9, 2024
07629c6
Merge news entries
nineteendo May 9, 2024
0fcffb5
Replace ampersand
nineteendo May 9, 2024
cae7a55
More refactoring
nineteendo May 13, 2024
cbf0bc4
Update generated code
nineteendo May 13, 2024
4c0a3f7
Fix path conversion
nineteendo May 13, 2024
5bf963e
Fix undefined variable
nineteendo May 13, 2024
71cb7f0
Add helper function
nineteendo May 13, 2024
24d2749
Apply suggestions from code review
nineteendo May 13, 2024
6edc3b3
Fix syntax error
nineteendo May 13, 2024
c6dae2c
Further refactoring
nineteendo May 13, 2024
05dd20e
Ternary operator
nineteendo May 13, 2024
2ced928
Fix attributes
nineteendo May 13, 2024
dfd4196
No inline
nineteendo May 13, 2024
7a7e942
Apply suggestions from code review
nineteendo May 13, 2024
50b3612
Update posixmodule.c
nineteendo May 13, 2024
eab1cb4
Update Modules/posixmodule.c
nineteendo May 13, 2024
6f6b07b
Update Modules/posixmodule.c
nineteendo May 13, 2024
0ca58a0
Update posixmodule.c
nineteendo May 13, 2024
3f1ea76
Update Modules/posixmodule.c
nineteendo May 13, 2024
222c58a
Update test_ntpath.py
nineteendo May 16, 2024
6e41cbf
Update Lib/test/test_ntpath.py
nineteendo May 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update Modules/posixmodule.c 
Co-authored-by: Thomas Grainger <tagrain@gmail.com>
  • Loading branch information
@nineteendo @graingert
nineteendo and graingert authored May 13, 2024
commit 3f1ea76fb9fa2d836e0496c23175ddfc76431d19
2 changes: 1 addition & 1 deletion Modules/posixmodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5102,7 +5102,7 @@ _testInfo(DWORD attributes, DWORD reparseTag, BOOL diskDevice, int testedType)
case PY_IFREG:
return diskDevice && attributes &&
!(attributes & FILE_ATTRIBUTE_DIRECTORY);
case PY_IFDIR:
case PY_IFDIR:
return attributes & FILE_ATTRIBUTE_DIRECTORY;
case PY_IFLNK:
return (attributes & FILE_ATTRIBUTE_REPARSE_POINT) &&
Expand Down