Skip to content

gh-119127: functools.partial placeholders #119827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rhettinger merged 78 commits into from
Sep 26, 2024
Merged

gh-119127: functools.partial placeholders #119827

Changes from 1 commit
Commits
Show all changes
78 commits
Select commit Hold shift + click to select a range
ee7333c
Initial Implementation
dg-pb May 21, 2024
8bcc462
serialization fix
dg-pb May 21, 2024
c67c9b4
bug fix
dg-pb May 21, 2024
680d900
Bug 2 fix
dg-pb May 21, 2024
9591ff5
Py_TPFLAGS_IMMUTABLETYPE added
dg-pb May 21, 2024
067e938
placeholder added to state as opposed to being used as global constant
dg-pb May 23, 2024
8af20b3
static removed
dg-pb May 23, 2024
607a0b1
creating sentinel via PyType_Spec
dg-pb May 23, 2024
f55801e
more accurate variable name
dg-pb May 23, 2024
5894145
trailing trim bug and tests
dg-pb May 24, 2024
3722e07
Updated docs
dg-pb May 24, 2024
a79c2af
blurb
dg-pb May 24, 2024
12aaa72
Merge branch 'main' into implement-119127
May 24, 2024
92c767b
minor edit
dg-pb May 24, 2024
496a9d2
doc fix
dg-pb May 24, 2024
38d9c11
better variable names and mini corrections
dg-pb May 31, 2024
707b957
Merge branch 'implement-119127' into implement-119127-again
dg-pb May 31, 2024
14b38ca
review comments mostly
dg-pb Jun 8, 2024
32bca19
singleton sentinel and reduce
dg-pb Jun 8, 2024
8576493
python module sentinel better mimics the one of the extension
dg-pb Jun 8, 2024
a3fd2d6
Emulated None behaviour, but using PyType_FromModuleAndSpec
dg-pb Jun 8, 2024
0852993
review feedback
dg-pb Jun 8, 2024
6fea348
included constant into tsv
dg-pb Jun 8, 2024
caec6e8
documentation update
dg-pb Jun 8, 2024
115b8c5
review edits
dg-pb Jun 9, 2024
3f5f00b
trailing placeholder prohibition and small changes
dg-pb Jun 9, 2024
202c929
change constant name in ignores
dg-pb Jun 9, 2024
2c16d38
PlaceholderType Hidden
dg-pb Jun 11, 2024
400ff55
support 4-arg pre-placeholder state
dg-pb Jun 20, 2024
8ccc38f
better variable names
dg-pb Jun 20, 2024
e7c82c7
partialmethod impl
dg-pb Jun 20, 2024
c9b7ef3
fix tests
dg-pb Jun 20, 2024
e59d711
adjust inspect to partial Placeholders
dg-pb Jun 20, 2024
7bfc591
arg alignment
dg-pb Jun 20, 2024
7957a97
small fixes
dg-pb Jun 21, 2024
8aaee6a
pickle compatibility ensured
dg-pb Jun 23, 2024
fe8e0ad
trailing placeholder test for __setstate__
dg-pb Jun 23, 2024
00dd80e
rough implementation rolled back and example of successive applicatio…
dg-pb Jun 24, 2024
d352cfa
small doc edits
dg-pb Jun 24, 2024
9038ed5
example changes
dg-pb Jun 24, 2024
49b8c71
serialization issues addressed
dg-pb Jun 25, 2024
bc1fdbd
delete redundant references
dg-pb Jun 25, 2024
3067221
simplify PyPlaceholder implementation
dg-pb Jun 25, 2024
1185510
more optimal python functools.partial
dg-pb Jun 25, 2024
266b4fa
placeholder arg and pre-placeholder instance conversions to positional
dg-pb Jun 25, 2024
dd58a12
unittest.mock.ANY test for Placeholder
dg-pb Jun 25, 2024
5971fbb
functools.partial.__get__
dg-pb Jun 26, 2024
9033650
Revert "functools.partial.__get__"
dg-pb Jun 26, 2024
d31e5d1
Merge branch 'main' into implement-119127-again
dg-pb Jun 26, 2024
a3d39b0
review changes
dg-pb Jun 26, 2024
9e4c5df
factor out repr. same to be used for partial and partialmethod
dg-pb Jun 27, 2024
16f12f8
microopt & args.count(Placeholder) can not be used as it uses __eq__
dg-pb Jun 27, 2024
82dd600
simplify preparation
dg-pb Jun 27, 2024
f9cb653
whatsnew + minor doc edit
dg-pb Jun 27, 2024
d255524
typo fixes
dg-pb Jun 27, 2024
404044e
whatsnew edit
dg-pb Jun 27, 2024
800217b
revert stylistic changes
dg-pb Jun 27, 2024
38ee450
factor out full __new__
dg-pb Jun 28, 2024
11f47db
Merge branch 'main' into implement-119127-again
serhiy-storchaka Jul 3, 2024
3c872bd
Merge branch 'main' into implement-119127-again
serhiy-storchaka Aug 11, 2024
fd16189
CR part 1
dg-pb Aug 12, 2024
a6c6ef2
CR Part 2
dg-pb Aug 12, 2024
1c8d73e
remove ignored global var
dg-pb Aug 12, 2024
a8bd3ae
CR changes
dg-pb Aug 12, 2024
70e47ed
small CR changes and doc updates
dg-pb Aug 12, 2024
2eacf5e
push placeholder check to earlier place
dg-pb Aug 12, 2024
f78d8d3
more appropriate test functions and better doc example
dg-pb Aug 13, 2024
0a8640e
minor fixes; message, doc polish
dg-pb Aug 13, 2024
6e3d282
better doc example and small test changes
dg-pb Aug 13, 2024
66c305d
assertRaisesRegex exact match
dg-pb Aug 14, 2024
14bf68c
doc nits
dg-pb Aug 14, 2024
ee642d5
Add Placeholder to __all__
rhettinger Sep 25, 2024
8d6c28e
Update copyright span
rhettinger Sep 25, 2024
8744bcb
Minor doc edits and add doctests
rhettinger Sep 25, 2024
b896470
Merge branch 'main' into implement-119127-again
rhettinger Sep 25, 2024
4881ae6
Merge branch 'main' into implement-119127-again
rhettinger Sep 25, 2024
c3ad7d9
Having the separate dict was necessary to eliminate duplicate keywords
rhettinger Sep 26, 2024
5e5d484
Merge branch 'main' into implement-119127-again
rhettinger Sep 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'main' into implement-119127-again
  • Loading branch information
@rhettinger
rhettinger authored Sep 25, 2024
commit 4881ae68efc88c07e4ed34e3eda920eb72ad1cda

This merge commit was added into this branch cleanly.

There are no new changes to show, but you can still view the diff.