Fix typos in docs, error messages and comments#122502
Conversation
Signed-off-by: jianghuyiyuan <shuangcui@live.com>
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
Thanks, but I think we can manage with these minor inconsistencies in the comments. |
|
This PR touches six files. Of the six files touched, three of the files are docs files, in which the PR fixes grammatical errors in the docs, and in a fourth file the PR fixes a spelling error in a message that could be shown to a user. I agree with @erlend-aasland that we don't want to encourage PRs that only fix typos in comments, but — despite its current title — that's not what this PR does. I think overall the changes this PR makes are valuable. |
|
Thanks @jianghuyiyuan for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
|
Sorry, @jianghuyiyuan and @AlexWaygood, I could not cleanly backport this to |
|
Sorry, @jianghuyiyuan and @AlexWaygood, I could not cleanly backport this to |
More specific a user who builds a debug build of CPython; the error message is guarded by the debug flag. |
|
Actually, we had a bunch of similar PRs that were accepted those past weeks (even when touching the C code) so I think we should have allowed this one as well: https://github.com/python/cpython/pulls?q=is%3Apr+author%3Axyb+sort%3Aupdated-desc (those are the PRs I rememebered) |
|
GH-122605 is a backport of this pull request to the 3.12 branch. |
(cherry-picked from commit 46f5a4f) Signed-off-by: jianghuyiyuan <shuangcui@live.com>
|
GH-122606 is a backport of this pull request to the 3.13 branch. |
(cherry-picked from commit 46f5a4f) Signed-off-by: jianghuyiyuan <shuangcui@live.com>
Signed-off-by: jianghuyiyuan <shuangcui@live.com>
📚 Documentation preview 📚: https://cpython-previews--122502.org.readthedocs.build/