Doc: Simplify the definition of 'soft deprecated'#124988
Conversation
bedevere-app
Bot
added
docs
There was a problem hiding this comment.
This is a good start towards a rewrite, thank you. I've suggested some further improvements inline:
The violation of line max width is intentional, as I once told it's better for diff purposes, at least in the PR stage.
This is fine but we should re-wrap before merge.
A
AA-Turner
added
needs backport to 3.12
AA-Turner
changed the title
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
|
@AA-Turner Thanks for the review! I have addressed all comments. Sorry if you already received a notification 😅 |
skirpichev
left a comment
skirpichev
left a comment
There was a problem hiding this comment.
LGTM, modulo two nitpicks (run fill-region in emacs, feel free to ignore).
PS: @andresdelfino, please avoid "Update branch" button, unless you are fixing merge conflicts or something like that (https://devguide.python.org/getting-started/pull-request-lifecycle/#update-branch-button).
Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
Co-authored-by: Carol Willing <carolcode@willingconsulting.com>
AA-Turner
left a comment
AA-Turner
left a comment
There was a problem hiding this comment.
Remove the final sentence per Carol and re-wrap.
|
Thanks @andresdelfino for the PR, and @AA-Turner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
(cherry picked from commit feca4cf) Co-authored-by: Andrés Delfino <adelfino@gmail.com> Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com> Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com> Co-authored-by: Carol Willing <carolcode@willingconsulting.com>
|
Sorry, @andresdelfino and @AA-Turner, I could not cleanly backport this to |
|
GH-125029 is a backport of this pull request to the 3.13 branch. |
|
GH-125030 is a backport of this pull request to the 3.12 branch. |
…125029) Doc: Simplify the definition of 'soft deprecated' (GH-124988) (cherry picked from commit feca4cf) Co-authored-by: Andrés Delfino <adelfino@gmail.com> Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com> Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com> Co-authored-by: Carol Willing <carolcode@willingconsulting.com>
4 participants
I found the definition of Soft deprecated somewhat complicated, and I wanted to give it a try.
The violation of line max width is intentional, as I was once told it's better for diff purposes, until merge.
📚 Documentation preview 📚: https://cpython-previews--124988.org.readthedocs.build/