gh-126081: For PRs labeled with "type-feature", require a core review - #126082
Merged
Conversation
ambv
added
type-feature
Contributor
Author
Behavior without a
|
hugovk
reviewed
Oct 28, 2024
hugovk
reviewed
Oct 28, 2024
hugovk
requested changes
Oct 28, 2024
hugovk
left a comment
hugovk
left a comment
Member
There was a problem hiding this comment.
(Checking what request-changes looks like)
|
When you're done making the requested changes, leave the comment: |
ezio-melotti
left a comment
ezio-melotti
left a comment
Member
There was a problem hiding this comment.
Can you add some inline comments to explain more clearly what each step does?
For example the "Check for type-feature" seem to only be used for the awaiting-merge check, whereas the "no required changes" can fail the build directly.
ambv
force-pushed
the
gh-126081-phase1
branch
from
October 28, 2024 16:48
4ef698f to
cb43754
Compare
Contributor
Author
|
I have made the requested changes; please review again. |
|
Thanks for making the requested changes! @hugovk: please review the changes made to this pull request. |
hugovk
approved these changes
Oct 28, 2024
Member
|
Looking good: 
|
ambv
enabled auto-merge (squash)
October 28, 2024 16:56
ezio-melotti
approved these changes
Oct 28, 2024
picnixz
pushed a commit
to picnixz/cpython
that referenced
this pull request
Dec 8, 2024
…review (pythonGH-126082) Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
ebonnal
pushed a commit
to ebonnal/cpython
that referenced
this pull request
Jan 12, 2025
…review (pythonGH-126082) Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is the test for this PR.