Skip to content

gh-128137: Update PyASCIIObject to handle interned field with the atomic operation #128196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
corona10 merged 19 commits into from
Jan 5, 2025
Merged

gh-128137: Update PyASCIIObject to handle interned field with the atomic operation #128196

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
45536d0
gh-128137: Split out interned field from state
corona10 Dec 23, 2024
f30b355
Address code review
corona10 Dec 23, 2024
18a8e6b
Maintain unused size as 24 bits
corona10 Dec 23, 2024
5c659ef
Reserve unused bit as 18 bits
corona10 Dec 23, 2024
c803475
Address code review
corona10 Dec 23, 2024
2dfd450
nit
corona10 Dec 23, 2024
69ad224
nit
corona10 Dec 23, 2024
b1b396b
Add NEWS.d
corona10 Dec 23, 2024
4327a6d
Resize struct padding
corona10 Dec 24, 2024
d86e0af
Update for WASI
corona10 Dec 24, 2024
f5c4d96
fix
corona10 Dec 24, 2024
53147e7
Address code review
corona10 Jan 1, 2025
30c2eb2
Use unsigned short instead
corona10 Jan 1, 2025
7d4955c
Address code review
corona10 Jan 2, 2025
958d0d7
Revert "Address code review"
corona10 Jan 2, 2025
fbc9c52
Add extra padding
corona10 Jan 2, 2025
2eaf1cf
Increase interned to 16bits and adjust layout
corona10 Jan 2, 2025
4fa26a8
fix
corona10 Jan 2, 2025
91907aa
nit
corona10 Jan 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
nit
  • Loading branch information
@corona10
corona10 committed Dec 23, 2024
commit 2dfd450879f94a4a9af6847ca784574974d4e394
16 changes: 8 additions & 8 deletions Include/cpython/unicodeobject.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,14 +102,14 @@ typedef struct {

struct {
/* If interned is non-zero, the two references from the
dictionary to this object are *not* counted in ob_refcnt.
The possible values here are:
0: Not Interned
1: Interned
2: Interned and Immortal
3: Interned, Immortal, and Static
This categorization allows the runtime to determine the right
cleanup mechanism at runtime shutdown. */
dictionary to this object are *not* counted in ob_refcnt.
The possible values here are:
0: Not Interned
1: Interned
2: Interned and Immortal
3: Interned, Immortal, and Static
This categorization allows the runtime to determine the right
cleanup mechanism at runtime shutdown. */
uint8_t interned;
/* Character size:

Expand Down
Loading