Skip to content

gh-129354: Fix grammar in PyErr_FormatUnraisable()#129475

Merged
vstinner merged 2 commits into
python:mainfrom
vstinner:format_unraisable_when
Jan 31, 2025
Merged

gh-129354: Fix grammar in PyErr_FormatUnraisable()#129475
vstinner merged 2 commits into
python:mainfrom
vstinner:format_unraisable_when

Conversation

@vstinner

@vstinner vstinner commented Jan 30, 2025

Copy link
Copy Markdown
Member

Replace "on verb+ing" with "when verb+ing".

@vstinner

Copy link
Copy Markdown
Member Author

cc @ambv @hoodmane @vsajip

@vstinner vstinner requested a review from rhettinger as a code owner January 30, 2025 14:27
@hoodmane

hoodmane commented Jan 30, 2025

Copy link
Copy Markdown
Contributor

As long as we're bikeshedding this, now I'm feeling like "while" is the most appropriate word. We are ignoring an error that occurred while whatever other action was in progress. "When" feels more appropriate for something that occurred at an instant, versus "while" for a duration. But it's pretty nitpicky...

Replace "on verb+ing" with "while verb+ing".
@vstinner

Copy link
Copy Markdown
Member Author

@hoodmane:

As long as we're bikeshedding this, now I'm feeling like "while" is the most appropriate word.

Oh, ok. I updated my PR to use "while". Would you mind to review the updated PR?

@hoodmane hoodmane left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the updated error messages read quite naturally. Thanks @vstinner!

@vstinner vstinner merged commit 95504f4 into python:main Jan 31, 2025
@vstinner vstinner deleted the format_unraisable_when branch January 31, 2025 08:45
@vstinner

Copy link
Copy Markdown
Member Author

Merged, thanks for the review @hoodmane.

srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants