gh-129269: Exclude everything in sys.path in test_coverage_ignore#130133
Closed
colesbury wants to merge 1 commit into
Closed
gh-129269: Exclude everything in sys.path in test_coverage_ignore#130133colesbury wants to merge 1 commit into
test_coverage_ignore#130133colesbury wants to merge 1 commit into
Conversation
…ore` The `test_trace.test_coverage_ignore` test would fail if you had `setuptools` installed, such as in `~/.local/lib/python3.xxx/site-packages/`. Ignore everything in `sys.path` when running the test.
colesbury
added
tests
|
🤖 New build scheduled with the buildbot fleet by @colesbury for commit d4efaf5 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F30617%2Fmerge If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again. |
bedevere-bot
removed
the
🔨 test-with-refleak-buildbots
hugovk
approved these changes
Feb 20, 2025
Member
hugovk
left a comment
hugovk
left a comment
There was a problem hiding this comment.
Was about to look into this, glad I searched the tracker first :)
This is reproducible on 3.12 as well, let's backport.
colesbury
added
needs backport to 3.12
Contributor
Author
|
Ugh, GitHub merged the PR into main, but hasn't marked the PR as merged: |
colesbury
added a commit
to colesbury/cpython
that referenced
this pull request
Feb 20, 2025
…age_ignore` (pythongh-130133) The `test_trace.test_coverage_ignore` test would fail if you had `setuptools` installed, such as in `~/.local/lib/python3.xxx/site-packages/`. Ignore everything in `sys.path` when running the test. (cherry picked from commit 35925e9) Co-authored-by: Sam Gross <colesbury@gmail.com>
|
GH-130357 is a backport of this pull request to the 3.13 branch. |
|
GH-130358 is a backport of this pull request to the 3.12 branch. |
Contributor
Author
|
This is merged. |
pull Bot
pushed a commit
to TechPenguineer/cpython
that referenced
this pull request
Feb 20, 2025
…ore` (pythongh-130133) The `test_trace.test_coverage_ignore` test would fail if you had `setuptools` installed, such as in `~/.local/lib/python3.xxx/site-packages/`. Ignore everything in `sys.path` when running the test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
test_trace.test_coverage_ignoretest would fail if you hadsetuptoolsinstalled, such as in~/.local/lib/python3.xxx/site-packages/. Ignore everything insys.pathwhen running the test.test_coverage_ignoreintest_tracefails if setuptools is installed #129269