Skip to content

gh-129824: fix data races in subinterpreters under TSAN #135794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kumaraditya303 merged 6 commits into from
Jul 4, 2025
+44 −17
Merged

gh-129824: fix data races in subinterpreters under TSAN #135794

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
bcc829e
fix data races in typeobject.c
kumaraditya303 Jun 21, 2025
64f25bf
more fixes
kumaraditya303 Jun 21, 2025
be846e8
Merge branch 'main' into interppool
kumaraditya303 Jun 23, 2025
3143552
code review
kumaraditya303 Jul 2, 2025
5d1d9b5
Merge branch 'main' into interppool
kumaraditya303 Jul 2, 2025
75c5ea1
assert Py_TPFLAGS_DISALLOW_INSTANTIATION on initial=0
kumaraditya303 Jul 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
assert Py_TPFLAGS_DISALLOW_INSTANTIATION on initial=0
  • Loading branch information
@kumaraditya303
kumaraditya303 committed Jul 4, 2025
commit 75c5ea1c69d2db6bf629c4adea7fc3492085b8c1
8 changes: 6 additions & 2 deletions Objects/typeobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9018,9 +9018,13 @@ type_ready_set_new(PyTypeObject *type, int initial)
default also inherit object.__new__. */
if (type->tp_new == NULL
&& base == &PyBaseObject_Type
&& !(type->tp_flags & Py_TPFLAGS_HEAPTYPE) && initial)
&& !(type->tp_flags & Py_TPFLAGS_HEAPTYPE))
{
type_add_flags(type, Py_TPFLAGS_DISALLOW_INSTANTIATION);
if (initial) {
type_add_flags(type, Py_TPFLAGS_DISALLOW_INSTANTIATION);
} else {
assert(type->tp_flags & Py_TPFLAGS_DISALLOW_INSTANTIATION);
}
}

if (!(type->tp_flags & Py_TPFLAGS_DISALLOW_INSTANTIATION)) {
Expand Down
Loading