Skip to content

GH-132732: Use pure op machinery to optimize various instructions with _POP_TOP and _POP_TWO #137577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
savannahostrowski merged 21 commits into from
Sep 15, 2025
Merged

GH-132732: Use pure op machinery to optimize various instructions with _POP_TOP and _POP_TWO #137577

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
b4b2106
_COMPARE_OP and _CONTAINS_OP
savannahostrowski Jul 26, 2025
cc4b9ce
add pop_top
savannahostrowski Jul 29, 2025
2d5f428
progress
savannahostrowski Jul 31, 2025
8e7023d
Merge branch 'main' into poptimize
savannahostrowski Jul 31, 2025
e75ca80
POP TOP
savannahostrowski Aug 5, 2025
3b37082
UNARY_NOT
savannahostrowski Aug 6, 2025
e7a1e7e
UNARY_NEGATIVE
savannahostrowski Aug 6, 2025
f69228a
UNARY_INVERT
savannahostrowski Aug 6, 2025
01a8e2a
Remove test
savannahostrowski Aug 9, 2025
443a924
Merge branch 'main' into poptimize
savannahostrowski Aug 9, 2025
49bd7c9
Add check for _
savannahostrowski Aug 9, 2025
2ada46b
📜🤖 Added by blurb_it.
blurb-it[bot] Aug 9, 2025
024690c
Address PR comments
savannahostrowski Aug 9, 2025
7945c19
Add back replace_op
savannahostrowski Aug 9, 2025
55d098f
Update cases
savannahostrowski Aug 9, 2025
4c614a0
Guard against booleans in unary_invert
savannahostrowski Aug 10, 2025
fc293dc
Merge branch 'main' into poptimize
savannahostrowski Sep 15, 2025
ef5b7c8
Address PR comments
savannahostrowski Sep 15, 2025
9cee967
Fix indentation
savannahostrowski Sep 15, 2025
b160d20
Fix indentation
savannahostrowski Sep 15, 2025
c6edbf9
Add newline
savannahostrowski Sep 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix indentation
  • Loading branch information
@savannahostrowski
savannahostrowski committed Sep 15, 2025
commit b160d20e489751af8141aa8b3150092cea226f41
18 changes: 1 addition & 17 deletions Python/optimizer_cases.c.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions Tools/cases_generator/optimizer_generator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,8 +247,8 @@ def replace_opcode_if_evaluates_pure(
if input_count in input_count_to_uop:
replacement_uop = input_count_to_uop[input_count]
input_desc = "one input" if input_count == 1 else "two inputs"
emitter.emit(f"""
if (sym_is_const(ctx, {outp.name})) {{
emitter.emit(
f"""if (sym_is_const(ctx, {outp.name})) {{
PyObject *result = sym_get_const(ctx, {outp.name});
if (_Py_IsImmortal(result)) {{
// Replace with {replacement_uop} since we have {input_desc} and an immortal result
Expand Down
Loading