gh-138970: Add general metadata system to the peg generator#138971
Merged
Conversation
pablogsal
force-pushed
the
gh-138970
branch
3 times, most recently
from
ed07998 to
12eeca7
Compare
Member
Author
|
I will use this later to make the invalid rules non implicit |
pablogsal
force-pushed
the
gh-138970
branch
2 times, most recently
from
f471328 to
f55196f
Compare
pablogsal
force-pushed
the
gh-138970
branch
from
f55196f to
4eeca29
Compare
lysnikolaou
reviewed
Sep 16, 2025
lysnikolaou
left a comment
lysnikolaou
left a comment
Member
There was a problem hiding this comment.
Looks good to me! That's gonna be useful! Left some minor comments.
lysnikolaou
reviewed
Sep 17, 2025
Member
|
Turns out we only run the tests on Buildbots. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.