Skip to content

gh-63016: Add flags parameter on mmap.flush #139553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vstinner merged 11 commits into from
Dec 27, 2025
Merged

gh-63016: Add flags parameter on mmap.flush #139553

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
eb249ef
Add flags parameter on mmap.flush
aisk Oct 4, 2025
1824344
Compatible on Windows
aisk Oct 4, 2025
7ab6d30
Merge remote-tracking branch 'upstream/main' into mmap-flush-flags
aisk Oct 11, 2025
7215d14
Update to use Argument Clinic
aisk Oct 11, 2025
05794b7
Fix document
aisk Oct 11, 2025
d32ed52
Merge branch 'main' into mmap-flush-flags
aisk Dec 23, 2025
5d48d65
Update generated files
aisk Dec 23, 2025
1706484
Apply suggestions from code review
aisk Dec 23, 2025
d790793
Add the missing blank line after resolve a merge conflict
aisk Dec 23, 2025
a471614
Update Doc/library/mmap.rst
aisk Dec 25, 2025
586fe8a
Update generated files
aisk Dec 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update to use Argument Clinic
  • Loading branch information
@aisk
aisk committed Oct 11, 2025
commit 7215d14cb5e942fe58352bea72e0877291d6edf9
2 changes: 1 addition & 1 deletion Lib/test/test_mmap.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1170,7 +1170,7 @@ def test_flush_parameters(self):
if hasattr(mmap, 'MS_ASYNC'):
m.flush(flags=mmap.MS_ASYNC)
if hasattr(mmap, 'MS_INVALIDATE'):
m.flush(PAGESIZE * 2, flags=mmap.MS_INVALIDATE)
m.flush(PAGESIZE * 2, mmap.MS_INVALIDATE)
if hasattr(mmap, 'MS_ASYNC') and hasattr(mmap, 'MS_INVALIDATE'):
m.flush(0, PAGESIZE, flags=mmap.MS_ASYNC | mmap.MS_INVALIDATE)

Expand Down
67 changes: 57 additions & 10 deletions Modules/clinic/mmapmodule.c.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 4 additions & 2 deletions Modules/mmapmodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1034,12 +1034,14 @@ mmap.mmap.flush
offset: Py_ssize_t = 0
size: Py_ssize_t = -1
/
flags: int = 0

[clinic start generated code]*/

static PyObject *
mmap_mmap_flush_impl(mmap_object *self, Py_ssize_t offset, Py_ssize_t size)
/*[clinic end generated code: output=956ced67466149cf input=c50b893bc69520ec]*/
mmap_mmap_flush_impl(mmap_object *self, Py_ssize_t offset, Py_ssize_t size,
int flags)
/*[clinic end generated code: output=4225f4174dc75a53 input=e79195ecf4f0a271]*/
{
CHECK_VALID(NULL);
if (size == -1) {
Expand Down
Loading