Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
gh-132657: add regression test for PySet_Contains with unhashable t…
…ype (GH-141411)

(cherry picked from commit 2ac738d)

Co-authored-by: M Bussonnier <bussonniermatthias@gmail.com>
  • Loading branch information
Carreau authored and miss-islington committed Nov 12, 2025
commit 97e547d5fa2cdbb087d1298f198db95021bf46b6
47 changes: 47 additions & 0 deletions Modules/_testlimitedcapi/set.c
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,51 @@ test_frozenset_add_in_capi(PyObject *self, PyObject *Py_UNUSED(obj))
return NULL;
}

static PyObject *
test_set_contains_does_not_convert_unhashable_key(PyObject *self, PyObject *Py_UNUSED(obj))
{
// See https://docs.python.org/3/c-api/set.html#c.PySet_Contains
PyObject *outer_set = PySet_New(NULL);

PyObject *needle = PySet_New(NULL);
if (needle == NULL) {
Py_DECREF(outer_set);
return NULL;
}

PyObject *num = PyLong_FromLong(42);
if (num == NULL) {
Py_DECREF(outer_set);
Py_DECREF(needle);
return NULL;
}

if (PySet_Add(needle, num) < 0) {
Py_DECREF(outer_set);
Py_DECREF(needle);
Py_DECREF(num);
return NULL;
}

int result = PySet_Contains(outer_set, needle);

Py_DECREF(num);
Py_DECREF(needle);
Py_DECREF(outer_set);

if (result < 0) {
if (PyErr_ExceptionMatches(PyExc_TypeError)) {
PyErr_Clear();
Py_RETURN_NONE;
}
return NULL;
}

PyErr_SetString(PyExc_AssertionError,
"PySet_Contains should have raised TypeError for unhashable key");
return NULL;
}

static PyMethodDef test_methods[] = {
{"set_check", set_check, METH_O},
{"set_checkexact", set_checkexact, METH_O},
Expand All @@ -174,6 +219,8 @@ static PyMethodDef test_methods[] = {
{"set_clear", set_clear, METH_O},

{"test_frozenset_add_in_capi", test_frozenset_add_in_capi, METH_NOARGS},
{"test_set_contains_does_not_convert_unhashable_key",
test_set_contains_does_not_convert_unhashable_key, METH_NOARGS},

{NULL},
};
Expand Down
Loading