Skip to content

gh-141571: Avoid redundant early _set_color() call in HelpFormatter #141611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
chillakalyan wants to merge 4 commits into from
Closed

gh-141571: Avoid redundant early _set_color() call in HelpFormatter #141611

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9bf2a5c
argparse: avoid redundant early _set_color() call in HelpFormatter.__…
chillakalyan Nov 16, 2025
485fa36
Add NEWS entry for gh-141571
chillakalyan Nov 16, 2025
fd0feae
📜🤖 Added by blurb_it.
blurb-it[bot] Nov 16, 2025
7453611
Add blurb-generated NEWS entry for gh-141571
chillakalyan Nov 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Lib/argparse.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ def __init__(
width = shutil.get_terminal_size().columns
width -= 2

self._set_color(color)
self._color = color
Copy link
Contributor

@hroncok hroncok Nov 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand where is this used.

Copy link
Contributor Author

@chillakalyan chillakalyan Nov 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review!
You're right — after checking the code path again, this self._color assignment is not actually used anywhere before _get_formatter() runs. I will check and i will report if i found the real issue

self._prog = prog
self._indent_increment = indent_increment
self._max_help_position = min(max_help_position,
Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Library/2025-11-16-06-33-31.gh-issue-141571.n2n0BX.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Avoid redundant color initialization in argparse.HelpFormatter. Patch by Chilla Kalyan.
Loading