Skip to content

gh-141780: Make PyModule_FromSlotsAndSpec enable GIL if needed #141785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
encukou merged 10 commits into from
Nov 24, 2025
Merged

gh-141780: Make PyModule_FromSlotsAndSpec enable GIL if needed #141785

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
13faf0f
gh-141780: Make PyModule_FromSlotsAndSpec enable GIL if needed
encukou Nov 20, 2025
60a669c
Make test.test_importlib and _testmultiphase importable in subinterpr…
encukou Nov 20, 2025
8a8a344
Test that Py_MOD_GIL_USED re-enables the GIL
encukou Nov 20, 2025
e2c9c7e
blurb
encukou Nov 20, 2025
b18c679
Pass with -Werror
encukou Nov 20, 2025
103f427
Skip test_from_modexport_empty_slots on GIL-ful builds
encukou Nov 20, 2025
91d59e9
Use @requires_subinterpreters
encukou Nov 20, 2025
3e82c25
Add more gil & interpreters slots
encukou Nov 20, 2025
5b8b87c
Fix assertion logic
encukou Nov 20, 2025
cde6c25
Python/import.c: PEP7
encukou Nov 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use @requires_subinterpreters
  • Loading branch information
@encukou
encukou committed Nov 20, 2025
commit 91d59e9b3985f984506a5f4b49be4f26f60479fe
5 changes: 4 additions & 1 deletion Lib/test/test_import/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import builtins
import concurrent.interpreters
import errno
import glob
import json
Expand Down Expand Up @@ -66,8 +65,10 @@
_testmultiphase = None
try:
import _interpreters
import concurrent.interpreters
except ModuleNotFoundError:
_interpreters = None
concurrent = None
try:
import _testinternalcapi
except ImportError:
Expand Down Expand Up @@ -3408,6 +3409,7 @@ def test_from_modexport(self):

self.assertEqual(module.__name__, modname)

@requires_subinterpreters
def test_from_modexport_gil_used(self):
# Test that a module with Py_MOD_GIL_USED (re-)enables the GIL.
# Do this in a new interpreter to avoid interfering with global state.
Expand Down Expand Up @@ -3461,6 +3463,7 @@ def test_from_modexport_create_nonmodule(self):
put_in_sys_modules=False)
self.assertIsInstance(module, str)

@requires_subinterpreters
def test_from_modexport_create_nonmodule_gil_used(self):
# Test that a module with Py_MOD_GIL_USED (re-)enables the GIL.
# Do this in a new interpreter to avoid interfering with global state.
Expand Down