Skip to content

gh-134584: Eliminate redundant refcounting from _UNPACK_SEQUENCE_TWO_TUPLE #142952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cocolato wants to merge 7 commits into from
Closed

gh-134584: Eliminate redundant refcounting from _UNPACK_SEQUENCE_TWO_TUPLE #142952

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
33baf2c
Eliminate redundant refcounting from UNPACK_SEQUENCE family
cocolato Dec 18, 2025
0d55ab9
Merge branch 'main' into feat/UNPACK_SEQUENCE2
cocolato Dec 22, 2025
c583aba
regen uop
cocolato Dec 22, 2025
2b2d04e
Merge branch 'main' into feat/UNPACK_SEQUENCE2
cocolato Jan 2, 2026
80a6ead
reduced to _UNPACK_SEQUENCE_TWO_TUPLE
cocolato Jan 2, 2026
e0f69ed
reduced to _UNPACK_SEQUENCE_TWO_TUPLE
cocolato Jan 2, 2026
64fc03d
Update Python/bytecodes.c
Fidget-Spinner Jan 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
reduced to _UNPACK_SEQUENCE_TWO_TUPLE
  • Loading branch information
@cocolato
cocolato committed Jan 2, 2026
commit e0f69edef327570efd775e09feb4b64ebecaaa27
6 changes: 0 additions & 6 deletions Python/optimizer_bytecodes.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1200,12 +1200,6 @@ dummy_func(void) {
}
}

op(_UNPACK_SEQUENCE_LIST, (seq -- values[oparg])) {
for (int i = 0; i < oparg; i++) {
values[i] = sym_new_not_null(ctx);
}
}

op(_CALL_TUPLE_1, (callable, null, arg -- res, a)) {
if (sym_matches_type(arg, &PyTuple_Type)) {
// e.g. tuple((1, 2)) or tuple(foo) where foo is known to be a tuple
Expand Down
4 changes: 2 additions & 2 deletions Python/optimizer_cases.c.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading