Skip to content

Conversation

@youknowone
Copy link
Contributor

@youknowone youknowone commented Dec 19, 2025

@aisk
Copy link
Contributor

aisk commented Jan 6, 2026

Hi, please check my comment in the original issue: #142966 (comment)

@encukou
Copy link
Member

encukou commented Jan 7, 2026

Thanks! Let's fix it even though it's deprecated.

Could you make this part of PyCPointerType_SetProto rather than add a new function that's always called after SetProto?

Please put the stginfo->format assignment in the STGINFO_LOCK block.

@youknowone
Copy link
Contributor Author

Thank you for the review!

@aisk
Copy link
Contributor

aisk commented Jan 18, 2026

Hi, please avoid force push in the future, see the Dev Guide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants