-
-
Notifications
You must be signed in to change notification settings - Fork 33.9k
gh-143754: Add Tkinter methods pack_content(), place_content() and grid_content() #143845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
gh-143754: Add Tkinter methods pack_content(), place_content() and grid_content() #143845
Conversation
|
The new stuff (on top of what is already in #143841) looks okay without closely examining every detail. |
|
I suggest we also:
|
|
To be nice, we should deprecate the old methods only when the new methods are available in all maintained Python versions, so the user can simply unconditionally switch to using the new methods. Since this change is just cosmetic, there is no need to even deprecate them in code. The code written 20 years ago will continue to work. We still test the |
…and grid_content() They use Tk commands with new name like "pack content instead of old "pack slaves".
92374bb to
999b0e6
Compare
hugovk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps we could soft deprecate until then?
Anyway, thanks for the PR.
|
There is no module documentation where the soft deprecation could be written. The docstrins now say "Synonym for ...". This is an equivalent of soft deprecation. You should not use these methods in new code if you do not support Python 3.14, but you are not forced to make mass renaming. I expect that nobody will use the new methods in the next 3 years. |
They use Tk commands with new name like "pack content instead of old "pack slaves".
Based on top of #143841.
tkintersource and docs use the word 'slave' #143754📚 Documentation preview 📚: https://cpython-previews--143845.org.readthedocs.build/