Skip to content

gh-145307: Defer loading psapi.dll until ctypes.util.dllist() is called.#145308

Merged
encukou merged 3 commits into
python:mainfrom
zooba:gh-145307
Mar 2, 2026
Merged

gh-145307: Defer loading psapi.dll until ctypes.util.dllist() is called.#145308
encukou merged 3 commits into
python:mainfrom
zooba:gh-145307

Conversation

@zooba

@zooba zooba commented Feb 27, 2026

Copy link
Copy Markdown
Member

@zooba

zooba commented Feb 27, 2026

Copy link
Copy Markdown
Member Author

That Android error appears to be network issues (accessing something off of GitHub), so it's not a problem with the PR. If it's a required check now, we can just retrigger it once the rest are done.

@zooba

zooba commented Feb 27, 2026

Copy link
Copy Markdown
Member Author

As expected, no other issues. So this is ready to merge if anyone wants to jump in with a review/comment (I'll leave it for a few days first, this is basically just a low priority perf/hardening measure, but it's an important good practice for us to follow to avoid adding high priority ones.)

@encukou

encukou commented Mar 2, 2026

Copy link
Copy Markdown
Member

Sure, let's do it. Though I'm about to soft-deprecate the other public function in this module :)

@encukou encukou merged commit 1cf5abe into python:main Mar 2, 2026
49 checks passed
@miss-islington-app

Copy link
Copy Markdown

Thanks @zooba for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 2, 2026
…s called. (pythonGH-145308)

(cherry picked from commit 1cf5abe)

Co-authored-by: Steve Dower <steve.dower@python.org>
@bedevere-app

bedevere-app Bot commented Mar 2, 2026

Copy link
Copy Markdown

GH-145427 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Mar 2, 2026
@zooba zooba deleted the gh-145307 branch March 2, 2026 16:27
zooba added a commit that referenced this pull request Mar 2, 2026
…ed. (GH-145308)

(cherry picked from commit 1cf5abe)

Co-authored-by: Steve Dower <steve.dower@python.org>
ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants