gh-146054: Limit the growth of encodings.search_function cache#146055
Merged
Conversation
picnixz
reviewed
Mar 17, 2026
picnixz
reviewed
Mar 17, 2026
serhiy-storchaka
approved these changes
Mar 17, 2026
serhiy-storchaka
left a comment
serhiy-storchaka
left a comment
Member
There was a problem hiding this comment.
LGTM, but lets see what @malemburg says.
Member
Author
|
Thanks for the reviews! The CI is not running :-(, updating the branch to try and fix it. |
StanFromIreland
added
needs backport to 3.13
|
Thanks @StanFromIreland for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
|
Thanks @StanFromIreland for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 17, 2026
pythonGH-146055) (cherry picked from commit 9d7621b) Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 17, 2026
pythonGH-146055) (cherry picked from commit 9d7621b) Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
|
GH-146067 is a backport of this pull request to the 3.14 branch. |
Member
Author
|
I think we can treat it as a bug fix, but I also don't feel strongly about it. |
|
GH-146068 is a backport of this pull request to the 3.13 branch. |
ljfp
pushed a commit
to ljfp/cpython
that referenced
this pull request
Apr 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
encodings.search_function()has an unbounded cache #146054