gh-71956: Fix IDLE Replace All searching up without wrap around#152737
Merged
Conversation
When the search direction is "Up" and "Wrap around" is off, Replace All replaced only the first match above the current position (and all matches below it). It now replaces all matches from the start of the text down to the current position, consistently with the "Up" direction.
serhiy-storchaka
added
needs backport to 3.13
|
Thanks @serhiy-storchaka for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15. |
|
GH-152799 is a backport of this pull request to the 3.15 branch. |
bedevere-app
Bot
removed
the
needs backport to 3.15
|
GH-152800 is a backport of this pull request to the 3.14 branch. |
|
GH-152801 is a backport of this pull request to the 3.13 branch. |
terryjreedy
pushed a commit
that referenced
this pull request
Jul 1, 2026
GH-152737) (#152801) gh-71956: Fix IDLE Replace All searching up without wrap around (GH-152737) When the search direction is "Up" and "Wrap around" is off, Replace All replaced only the first match above the current position (and all matches below it). It now replaces all matches from the start of the text down to the current position, consistently with the "Up" direction. (cherry picked from commit ef27e5b) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
terryjreedy
pushed a commit
that referenced
this pull request
Jul 1, 2026
GH-152737) (#152800) gh-71956: Fix IDLE Replace All searching up without wrap around (GH-152737) When the search direction is "Up" and "Wrap around" is off, Replace All replaced only the first match above the current position (and all matches below it). It now replaces all matches from the start of the text down to the current position, consistently with the "Up" direction. (cherry picked from commit ef27e5b) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
terryjreedy
pushed a commit
that referenced
this pull request
Jul 1, 2026
GH-152737) (#152799) gh-71956: Fix IDLE Replace All searching up without wrap around (GH-152737) When the search direction is "Up" and "Wrap around" is off, Replace All replaced only the first match above the current position (and all matches below it). It now replaces all matches from the start of the text down to the current position, consistently with the "Up" direction. (cherry picked from commit ef27e5b) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the editor's Replace dialog, Replace All with the search direction set to "Up" and "Wrap around" off replaced only the first match above the current position (and, wrongly, all matches below it).
It searched backwards for the first match, then replaced forwards from there to the end of the text. Now, for a backward search without wrap, it replaces top-to-bottom from the start of the text down to the first match at or above the current position — consistently with the "Up" direction. A mark tracks that stop point across the edits.
Minimal reproducer (
|is the cursor):Search
a, replace withb, direction "Up", "Wrap around" off, Replace All.Before:
a / b / b. After:b / b / a.Tests now cover all four direction/wrap-around combinations.
🤖 Generated with Claude Code