Skip to content

[3.7] bpo-38178: Don't explicitly pass "loop" to EchoClientProtocol. (GH-16159) #16162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
miss-islington merged 1 commit into from
Sep 15, 2019
Merged

[3.7] bpo-38178: Don't explicitly pass "loop" to EchoClientProtocol. (GH-16159) #16162

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions Doc/library/asyncio-protocol.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -767,9 +767,8 @@ data, and waits until the connection is closed::


class EchoClientProtocol(asyncio.Protocol):
def __init__(self, message, on_con_lost, loop):
def __init__(self, message, on_con_lost):
self.message = message
self.loop = loop
self.on_con_lost = on_con_lost

def connection_made(self, transport):
Expand Down Expand Up @@ -869,11 +868,10 @@ method, sends data and closes the transport when it receives the answer::


class EchoClientProtocol:
def __init__(self, message, loop):
def __init__(self, message, on_con_lost):
self.message = message
self.loop = loop
self.transport = None
self.on_con_lost = loop.create_future()
self.on_con_lost = on_con_lost

def connection_made(self, transport):
self.transport = transport
Expand All @@ -899,13 +897,15 @@ method, sends data and closes the transport when it receives the answer::
# low-level APIs.
loop = asyncio.get_running_loop()

on_con_lost = loop.create_future()
message = "Hello World!"

transport, protocol = await loop.create_datagram_endpoint(
lambda: EchoClientProtocol(message, loop),
lambda: EchoClientProtocol(message, on_con_lost),
remote_addr=('127.0.0.1', 9999))

try:
await protocol.on_con_lost
await on_con_lost
finally:
transport.close()

Expand Down