Skip to content

minor formatting improvements and fixes to idle.rst#17165

Merged
terryjreedy merged 2 commits into
python:masterfrom
taleinat:minor-idle-docs-formatting
Jan 5, 2020
Merged

minor formatting improvements and fixes to idle.rst#17165
terryjreedy merged 2 commits into
python:masterfrom
taleinat:minor-idle-docs-formatting

Conversation

@taleinat

@taleinat taleinat commented Nov 15, 2019

Copy link
Copy Markdown
Contributor

No description provided.

@taleinat taleinat requested a review from terryjreedy November 15, 2019 07:36
csabella
csabella approved these changes Jan 5, 2020
View reviewed changes

@csabella csabella left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch on these! LGTM

@terryjreedy

terryjreedy commented Jan 5, 2020

Copy link
Copy Markdown
Member

Thank you both for the changes and review. I checked that idle.html looks good (better), with no added glitches, in our viewer.

@terryjreedy terryjreedy merged commit d6c08db into python:master Jan 5, 2020
@miss-islington

miss-islington commented Jan 5, 2020

Copy link
Copy Markdown
Contributor

Thanks @taleinat for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

@bedevere-bot

bedevere-bot commented Jan 5, 2020

Copy link
Copy Markdown

GH-17849 is a backport of this pull request to the 3.8 branch.

@bedevere-bot

bedevere-bot commented Jan 5, 2020

Copy link
Copy Markdown

GH-17850 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 5, 2020
@taleinat @miss-islington
Minor formatting improvements and fixes to idle.rst (pythonGH-17165)
92fde9e 
(cherry picked from commit d6c08db)

Co-authored-by: Tal Einat <taleinat+github@gmail.com>
miss-islington added a commit that referenced this pull request Jan 6, 2020
@miss-islington @taleinat
Minor formatting improvements and fixes to idle.rst (GH-17165)
5a065ac 
(cherry picked from commit d6c08db)

Co-authored-by: Tal Einat <taleinat+github@gmail.com>
@miss-islington

miss-islington commented Jan 6, 2020

Copy link
Copy Markdown
Contributor

Thanks @taleinat for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@bedevere-bot

bedevere-bot commented Jan 6, 2020

Copy link
Copy Markdown

GH-17859 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 6, 2020
@taleinat @miss-islington
Minor formatting improvements and fixes to idle.rst (pythonGH-17165)
d5b1970 
(cherry picked from commit d6c08db)

Co-authored-by: Tal Einat <taleinat+github@gmail.com>
@terryjreedy

terryjreedy commented Jan 6, 2020

Copy link
Copy Markdown
Member

First 3.7 backport suffered intermittent failure not related to IDLE. Auto-backport tests cannot be restarted, that I know of, so close and start over.

miss-islington added a commit that referenced this pull request Jan 6, 2020
@miss-islington @taleinat
Minor formatting improvements and fixes to idle.rst (GH-17165)
54bcd65 
(cherry picked from commit d6c08db)

Co-authored-by: Tal Einat <taleinat+github@gmail.com>
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
@taleinat @shihai1991
Minor formatting improvements and fixes to idle.rst (pythonGH-17165)
39b8670
@taleinat taleinat deleted the minor-idle-docs-formatting branch May 26, 2020 12:14
@taleinat taleinat restored the minor-idle-docs-formatting branch May 26, 2020 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@csabella csabella csabella approved these changes
@terryjreedy terryjreedy Awaiting requested review from terryjreedy

Assignees

@terryjreedy terryjreedy

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@taleinat @terryjreedy @miss-islington @bedevere-bot @csabella @the-knights-who-say-ni