Improve grammar in the import system reference documentation by Bonifacio2 · Pull Request #18209 · python/cpython

Bonifacio2 · 2020-01-27T18:57:19Z

Replaced the period with a comma.

Automerge-Triggered-By: @Mariatta

the-knights-who-say-ni · 2020-01-27T18:57:22Z

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@Bonifacio2

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

cjw296 · 2020-01-28T14:47:59Z


 To indicate to the import machinery that the spec represents a namespace
-:term:`portion`. the path entry finder sets "loader" on the spec to
+:term:`portion` the path entry finder sets "loader" on the spec to


This should be a comma, not a space.

brandtbucher

Thanks for your time @Bonifacio2, and welcome to CPython! 😎

I assume that you've seen the bot's message about the CLA?

Co-Authored-By: Brandt Bucher <brandtbucher@gmail.com>

Bonifacio2 · 2020-01-28T18:32:10Z

Thanks for your time @Bonifacio2, and welcome to CPython! 😎

I assume that you've seen the bot's message about the CLA?

Yes, I saw it. I already created my b.p.o account, set the github account, signed the agreement, received my certificate, but https://check-python-cla.herokuapp.com/ still says I haven't signed the CLA.

brandtbucher · 2020-01-28T18:38:11Z

Okay, I'd give it a business day or two then before it's marked as received. It's my understanding that they're processed manually by a human at the PSF.

Mariatta

Thanks!

Bonifacio2 · 2020-01-28T18:50:52Z

Hello, @Mariatta . Should I open the backport PRs for the 3.7 and 3.8 branches now or should I wait for this to be merged?

brandtbucher · 2020-01-28T18:51:45Z

The bot will open them automatically. Your work here is done!

cjw296 · 2020-01-28T19:10:52Z

@Mariatta - where can I find out what the automerge tag does? How come I appear to be able to merge this PR even though CLA is still not signed?

Mariatta · 2020-01-29T17:44:36Z

@cjw296 The PR will be automatically merged by @miss-islington if all of the following are true:

PR has automerge label
PR has CLA signed label
PR has awaiting merge label (has been reviewed and approved by a core dev)
all checks and tests in the PR have passed
PR does not have DO NOT MERGE label

Additionally, automerge takes care of replacing the "#NNNN" into "GH-NNNN" in the commit message.
Automerge also uses the PR description and PR body as the commit message. This is helpful in case of multiple commits in PR.

Through GitHub web UI, the only restriction it has is that you must have commit right, and that all checks pass. Core dev can use their own judgement and bypass the CLA check if they see fit. In the past, some of us would bypass CLA check if it is simple typo fixes. Personally for me though, I rather have CLA always signed, and let the bot do the merging.

Hope this helps.

cjw296 · 2020-01-29T18:23:20Z

perfect, thankyou!

miss-islington · 2020-01-30T02:23:53Z

Thanks @Bonifacio2 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

bedevere-bot · 2020-01-30T02:24:08Z

GH-18268 is a backport of this pull request to the 3.8 branch.

@Mariatta

…H-18209) Replaced the period with a comma. Automerge-Triggered-By: @Mariatta (cherry picked from commit d47d0c8) Co-authored-by: Bonifacio de Oliveira <bonifacio.segundo@gmail.com>

bedevere-bot · 2020-01-30T02:24:15Z

GH-18269 is a backport of this pull request to the 3.7 branch.

@Mariatta

…H-18209) Replaced the period with a comma. Automerge-Triggered-By: @Mariatta (cherry picked from commit d47d0c8) Co-authored-by: Bonifacio de Oliveira <bonifacio.segundo@gmail.com>

brandtbucher · 2020-01-30T02:35:05Z

Congrats on your first CPython contribution @Bonifacio2! 🍾

Looking forward to seeing more from you in the future.

@Mariatta

…H-18209) Replaced the period with a comma. Automerge-Triggered-By: @Mariatta

@Mariatta

Replaced the period with a comma. Automerge-Triggered-By: @Mariatta (cherry picked from commit d47d0c8) Co-authored-by: Bonifacio de Oliveira <bonifacio.segundo@gmail.com>

@Mariatta

Replaced the period with a comma. Automerge-Triggered-By: @Mariatta (cherry picked from commit d47d0c8) Co-authored-by: Bonifacio de Oliveira <bonifacio.segundo@gmail.com>

fix typo

fa0799a

the-knights-who-say-ni added the CLA not signed label Jan 27, 2020

bedevere-bot added docs Documentation in the Doc dir awaiting review labels Jan 27, 2020

cjw296 reviewed Jan 28, 2020

View reviewed changes

brandtbucher added skip issue skip news labels Jan 28, 2020

brandtbucher requested changes Jan 28, 2020

View reviewed changes

Comment thread Doc/reference/import.rst Outdated

bedevere-bot added awaiting core review and removed awaiting review labels Jan 28, 2020

fix typo on Doc/reference/import.rst

4845c3b

Co-Authored-By: Brandt Bucher <brandtbucher@gmail.com>

Mariatta approved these changes Jan 28, 2020

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting core review labels Jan 28, 2020

Mariatta added 🤖 automerge labels Jan 28, 2020

Mariatta changed the title ~~fix typo~~ Improve grammar in the import system reference documentation Jan 29, 2020

csabella removed the CLA not signed label Jan 30, 2020

the-knights-who-say-ni added the CLA signed label Jan 30, 2020

miss-islington merged commit d47d0c8 into python:master Jan 30, 2020

bedevere-bot removed the awaiting merge label Jan 30, 2020

bedevere-bot removed the needs backport to 3.8 label Jan 30, 2020

bedevere-bot removed the needs backport to 3.7 label Jan 30, 2020

shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020

Improve grammar in the import system reference documentation (pythonG…

7ccff0c

…H-18209) Replaced the period with a comma. Automerge-Triggered-By: @Mariatta

Uh oh!

Uh oh!

Conversation

Bonifacio2 commented Jan 27, 2020 • edited by Mariatta Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

the-knights-who-say-ni commented Jan 27, 2020

Recognized GitHub username

Uh oh!

cjw296 Jan 28, 2020

Choose a reason for hiding this comment

Uh oh!

brandtbucher left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Bonifacio2 commented Jan 28, 2020

Uh oh!

brandtbucher commented Jan 28, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Mariatta left a comment

Choose a reason for hiding this comment

Uh oh!

Bonifacio2 commented Jan 28, 2020

Uh oh!

brandtbucher commented Jan 28, 2020

Uh oh!

cjw296 commented Jan 28, 2020

Uh oh!

Mariatta commented Jan 29, 2020

Uh oh!

cjw296 commented Jan 29, 2020

Uh oh!

miss-islington commented Jan 30, 2020

Uh oh!

bedevere-bot commented Jan 30, 2020

Uh oh!

bedevere-bot commented Jan 30, 2020

Uh oh!

brandtbucher commented Jan 30, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Bonifacio2 commented Jan 27, 2020 •

edited by Mariatta

Loading

brandtbucher commented Jan 28, 2020 •

edited

Loading