bpo-27635: Fix pickle documentation about __new__ not being called. - #19269
Merged
Conversation
furkanonder
changed the title
pitrou
changed the title
__new__ not being called.
pitrou
approved these changes
Apr 18, 2020
pitrou
left a comment
pitrou
left a comment
Member
There was a problem hiding this comment.
+1. I improved the wording and will merge if CI passes.
Contributor
|
@furkanonder: Status check is done, and it's a failure ❌ . |
Contributor
|
@furkanonder: Status check is done, and it's a success ✅ . |
1 similar comment
Contributor
|
@furkanonder: Status check is done, and it's a success ✅ . |
Contributor
|
Sorry, I can't merge this PR. Reason: |
Contributor
|
Thanks @furkanonder for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Apr 18, 2020
…pythonGH-19269) Automerge-Triggered-By: @pitrou (cherry picked from commit 482259d) Co-authored-by: Furkan Önder <furkantahaonder@gmail.com>
|
GH-19585 is a backport of this pull request to the 3.8 branch. |
|
GH-19586 is a backport of this pull request to the 3.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Apr 18, 2020
…pythonGH-19269) Automerge-Triggered-By: @pitrou (cherry picked from commit 482259d) Co-authored-by: Furkan Önder <furkantahaonder@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue27635
Automerge-Triggered-By: @pitrou