Skip to content

bpo-40196: Fix a bug in the symtable when reporting inspecting global variables #19391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pablogsal merged 2 commits into from
Apr 6, 2020
Merged

bpo-40196: Fix a bug in the symtable when reporting inspecting global variables #19391

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2c52106
bpo-40196: Fix a bug in the symtable when reporting inspecting global…
pablogsal Apr 6, 2020
94a1930
Update Misc/NEWS.d/next/Library/2020-04-06-11-05-13.bpo-40196.Jqowse.rst
pablogsal Apr 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Lib/symtable.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ def is_declared_global(self):
return bool(self.__scope == GLOBAL_EXPLICIT)

def is_local(self):
return bool(self.__flags & DEF_BOUND)
return bool(self.__scope in (LOCAL, CELL))

def is_annotated(self):
return bool(self.__flags & DEF_ANNOT)
Expand Down
6 changes: 5 additions & 1 deletion Lib/test/test_symtable.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,7 @@ def test_globals(self):
self.assertTrue(self.spam.lookup("bar").is_declared_global())
self.assertFalse(self.internal.lookup("x").is_global())
self.assertFalse(self.Mine.lookup("instance_var").is_global())
self.assertTrue(self.spam.lookup("bar").is_global())

def test_nonlocal(self):
self.assertFalse(self.spam.lookup("some_var").is_nonlocal())
Expand All @@ -108,7 +109,10 @@ def test_nonlocal(self):

def test_local(self):
self.assertTrue(self.spam.lookup("x").is_local())
self.assertFalse(self.internal.lookup("x").is_local())
self.assertFalse(self.spam.lookup("bar").is_local())

def test_free(self):
self.assertTrue(self.internal.lookup("x").is_free())

def test_referenced(self):
self.assertTrue(self.internal.lookup("x").is_referenced())
Expand Down
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Library/2020-04-06-11-05-13.bpo-40196.Jqowse.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Fix a bug in the :mod:`symtable` module that was causing incorrectly report
global variables as local. Patch by Pablo Galindo.