Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add quotes around the node type
  • Loading branch information
pablogsal committed May 15, 2020
commit 6d1d63cfe9cb6067cbd00546d27537b0f7e85506
2 changes: 1 addition & 1 deletion Grammar/python.gram
Original file line number Diff line number Diff line change
Expand Up @@ -647,7 +647,7 @@ invalid_assignment:
| a=star_expressions augassign (yield_expr | star_expressions) {
RAISE_SYNTAX_ERROR_KNOWN_LOCATION(
a,
"%s is an illegal expression for augmented assignment",
"'%s' is an illegal expression for augmented assignment",
_PyPegen_get_expr_name(a)
)}

Expand Down
12 changes: 6 additions & 6 deletions Lib/test/test_syntax.py
Original file line number Diff line number Diff line change
Expand Up @@ -138,15 +138,15 @@

>>> a, b += 1, 2
Traceback (most recent call last):
SyntaxError: tuple is an illegal expression for augmented assignment
SyntaxError: 'tuple' is an illegal expression for augmented assignment

>>> (a, b) += 1, 2
Traceback (most recent call last):
SyntaxError: tuple is an illegal expression for augmented assignment
SyntaxError: 'tuple' is an illegal expression for augmented assignment

>>> [a, b] += 1, 2
Traceback (most recent call last):
SyntaxError: list is an illegal expression for augmented assignment
SyntaxError: 'list' is an illegal expression for augmented assignment

From compiler_complex_args():

Expand Down Expand Up @@ -353,16 +353,16 @@

>>> (x for x in x) += 1
Traceback (most recent call last):
SyntaxError: generator expression is an illegal expression for augmented assignment
SyntaxError: 'generator expression' is an illegal expression for augmented assignment
>>> None += 1
Traceback (most recent call last):
SyntaxError: None is an illegal expression for augmented assignment
SyntaxError: 'None' is an illegal expression for augmented assignment
>>> __debug__ += 1
Traceback (most recent call last):
SyntaxError: cannot assign to __debug__
>>> f() += 1
Traceback (most recent call last):
SyntaxError: function call is an illegal expression for augmented assignment
SyntaxError: 'function call' is an illegal expression for augmented assignment


Test continue in finally in weird combinations.
Expand Down
2 changes: 1 addition & 1 deletion Parser/pegen/parse.c
Original file line number Diff line number Diff line change
Expand Up @@ -10875,7 +10875,7 @@ invalid_assignment_rule(Parser *p)
(_tmp_129_var = _tmp_129_rule(p)) // yield_expr | star_expressions
)
{
_res = RAISE_SYNTAX_ERROR_KNOWN_LOCATION ( a , "%s is an illegal expression for augmented assignment" , _PyPegen_get_expr_name ( a ) );
_res = RAISE_SYNTAX_ERROR_KNOWN_LOCATION ( a , "'%s' is an illegal expression for augmented assignment" , _PyPegen_get_expr_name ( a ) );
if (_res == NULL && PyErr_Occurred()) {
p->error_indicator = 1;
return NULL;
Expand Down
2 changes: 1 addition & 1 deletion Python/ast.c
Original file line number Diff line number Diff line change
Expand Up @@ -3173,7 +3173,7 @@ ast_for_expr_stmt(struct compiling *c, const node *n)
case Subscript_kind:
break;
default:
ast_error(c, ch, "%s is an illegal expression for augmented assignment",
ast_error(c, ch, "'%s' is an illegal expression for augmented assignment",
get_expr_name(expr1));
return NULL;
}
Expand Down