bpo-28681: Clarify multiple function names in the tutorial#21340
Merged
nanjekyejoannah merged 2 commits intopython:masterfrom Jul 6, 2020
Merged
bpo-28681: Clarify multiple function names in the tutorial#21340nanjekyejoannah merged 2 commits intopython:masterfrom
nanjekyejoannah merged 2 commits intopython:masterfrom
Conversation
terryjreedy
requested changes
Jul 6, 2020
|
When you're done making the requested changes, leave the comment: |
terryjreedy
changed the title
Member
|
Guido strongly prefers and the devguide now clearly states that the first message line of a merged commit should be an active tense statement, like the first line of docstrings. (I would say "Should start with an active verb" except that there might be a short introductory phrase.) This is easier to ensure if the default, the PR title, is written that way. Hence my edit. |
terryjreedy
approved these changes
Jul 6, 2020
Contributor
|
Thanks @nanjekyejoannah for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 6, 2020
|
GH-21343 is a backport of this pull request to the 3.9 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 6, 2020
Contributor
Author
|
Thanks for the review @terryjreedy |
|
GH-21344 is a backport of this pull request to the 3.8 branch. |
nanjekyejoannah
added a commit
that referenced
this pull request
Jul 6, 2020
…GH-21343) * improve control flow docs * Add also Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu> Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu> (cherry picked from commit d12af71) Co-authored-by: Joannah Nanjekye <33177550+nanjekyejoannah@users.noreply.github.com> Co-authored-by: Joannah Nanjekye <33177550+nanjekyejoannah@users.noreply.github.com>
nanjekyejoannah
added a commit
that referenced
this pull request
Jul 6, 2020
…GH-21344) * improve control flow docs * Add also Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu> Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu> (cherry picked from commit d12af71) Co-authored-by: Joannah Nanjekye <33177550+nanjekyejoannah@users.noreply.github.com> Co-authored-by: Joannah Nanjekye <33177550+nanjekyejoannah@users.noreply.github.com>
shihai1991
pushed a commit
to shihai1991/cpython
that referenced
this pull request
Jul 6, 2020
…21340) * improve control flow docs * Add also Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu> Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merged ideas from @bitdancer and @terryjreedy in the bpo thread.
https://bugs.python.org/issue28681