Skip to content

bpo-41316: Make tarfile follow specs for FNAME #21511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
miss-islington merged 6 commits into from
Sep 7, 2020
Merged

bpo-41316: Make tarfile follow specs for FNAME #21511

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5639f66
bpo-41316: Make tarfile follow specs for FNAME
ArtemSBulgakov Jul 16, 2020
6f751fe
📜🤖 Added by blurb_it.
blurb-it[bot] Jul 28, 2020
4a8bd29
Update ACKS
ArtemSBulgakov Jul 28, 2020
3948880
Add test capturing missed expectation when the path appears in the re…
jaraco Sep 7, 2020
0bbaa1c
Merge branch 'bpo-41316-test' into bpo-41316
jaraco Sep 7, 2020
4baaf5e
Reference RFC and precise language for easier searching.
jaraco Sep 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion Lib/test/test_tarfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1416,12 +1416,15 @@ def write(self, data):
pax_headers={'non': 'empty'})
self.assertFalse(f.closed)


class GzipWriteTest(GzipTest, WriteTest):
pass


class Bz2WriteTest(Bz2Test, WriteTest):
pass


class LzmaWriteTest(LzmaTest, WriteTest):
pass

Expand Down Expand Up @@ -1464,8 +1467,17 @@ def test_file_mode(self):
finally:
os.umask(original_umask)


class GzipStreamWriteTest(GzipTest, StreamWriteTest):
pass
def test_source_directory_not_leaked(self):
"""
Ensure the source directory is not included in the tar header
per bpo-41316.
"""
tarfile.open(tmpname, self.mode).close()
payload = pathlib.Path(tmpname).read_text(encoding='latin-1')
assert os.path.dirname(tmpname) not in payload


class Bz2StreamWriteTest(Bz2Test, StreamWriteTest):
decompressor = bz2.BZ2Decompressor if bz2 else None
Expand Down