Skip to content

bpo-41331: Doc: fix import of asdl.py when called from outside Doc/. - #21529

Merged
JulienPalard merged 1 commit into
python:masterfrom
JulienPalard:asdl-import
Jul 20, 2020
Merged

bpo-41331: Doc: fix import of asdl.py when called from outside Doc/.#21529
JulienPalard merged 1 commit into
python:masterfrom
JulienPalard:asdl-import

Conversation

@JulienPalard

@JulienPalard JulienPalard commented Jul 18, 2020 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@JulienPalard
JulienPalard requested a review from isidentical July 18, 2020 08:31
isidentical
isidentical approved these changes Jul 18, 2020
View reviewed changes

@isidentical isidentical left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JulienPalard
JulienPalard merged commit 7f03445 into python:master Jul 20, 2020
@isidentical

isidentical commented Jul 20, 2020

Copy link
Copy Markdown
Member

@JulienPalard do we need a backport?

@JulienPalard
JulienPalard deleted the asdl-import branch July 20, 2020 08:27
@JulienPalard

JulienPalard commented Jul 20, 2020

Copy link
Copy Markdown
Member Author

Yes a backport in 3.9 would be great, @ambv is that ok?

@miss-islington

miss-islington commented Jul 20, 2020

Copy link
Copy Markdown
Contributor

Thanks @JulienPalard for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@bedevere-bot

bedevere-bot commented Jul 20, 2020

Copy link
Copy Markdown

GH-21567 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 20, 2020
@JulienPalard @miss-islington
Doc: fix import of asdl.py when called from outside Doc/. (pythonGH-2…
e2cca87 
…1529)

(cherry picked from commit 7f03445)

Co-authored-by: Julien Palard <julien@palard.fr>
ambv pushed a commit that referenced this pull request Jul 20, 2020
@miss-islington @JulienPalard
Doc: fix import of asdl.py when called from outside Doc/. (GH-21529) (#…
9464783 
…21567)

(cherry picked from commit 7f03445)

Co-authored-by: Julien Palard <julien@palard.fr>
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Aug 4, 2020
@JulienPalard @shihai1991
Doc: fix import of asdl.py when called from outside Doc/. (pythonGH-2…
9264f19 
…1529)
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Aug 20, 2020
@JulienPalard @shihai1991
Doc: fix import of asdl.py when called from outside Doc/. (pythonGH-2…
fcfeef5 
…1529)
xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
@JulienPalard @xzy3-cdc
Doc: fix import of asdl.py when called from outside Doc/. (pythonGH-2…
fbd0926 
…1529)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@isidentical isidentical isidentical approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@JulienPalard @isidentical @miss-islington @bedevere-bot @ambv @the-knights-who-say-ni