bpo-41338: Fix warnings in test_decimal - #21542
Merged
Merged
Conversation
methane
added
type-bug
Member
Author
|
@serhiy-storchaka What do you think about suppress DeprecationWarning in |
Member
I think it is a good idea. Actually I have wrote a PR #21543 that implements it simultaneously with you. 😉 |
serhiy-storchaka
approved these changes
Jul 19, 2020
serhiy-storchaka
left a comment
serhiy-storchaka
left a comment
Member
There was a problem hiding this comment.
👍
It is up to you, mark with ignore_warnings individual tests or change requires_legacy_unicode_capi.
skrah
approved these changes
Jul 19, 2020
Contributor
|
Actually, we could delete this test if it's too much trouble. It has run for several years and the code won't change. |
shihai1991
pushed a commit
to shihai1991/cpython
that referenced
this pull request
Aug 4, 2020
shihai1991
pushed a commit
to shihai1991/cpython
that referenced
this pull request
Aug 20, 2020
xzy3
pushed a commit
to xzy3/cpython
that referenced
this pull request
Oct 18, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue41338