Skip to content

typo-ish: improved comment that indicates state of Barrier#23755

Closed
cpriyank wants to merge 2 commits into
python:3.9from
cpriyank:patch-1
Closed

typo-ish: improved comment that indicates state of Barrier#23755
cpriyank wants to merge 2 commits into
python:3.9from
cpriyank:patch-1

Conversation

@cpriyank

Copy link
Copy Markdown
Contributor

removed extra comma in comment that indicates state of a Barrier as it was confusing and breaking the flow while reading. Also added missing space after # that began the comment

removed extra comma in comment that indicates state of a `Barrier` as it was confusing and breaking the flow while reading
@the-knights-who-say-ni

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@cpriyank

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@cpriyank cpriyank changed the title typo-ish: improved comment that indicates state of Barrier skip-issue: typo-ish: improved comment that indicates state of Barrier Dec 13, 2020
@cpriyank cpriyank changed the title skip-issue: typo-ish: improved comment that indicates state of Barrier skip issue: typo-ish: improved comment that indicates state of Barrier Dec 13, 2020
@cpriyank cpriyank changed the title skip issue: typo-ish: improved comment that indicates state of Barrier typo-ish: improved comment that indicates state of Barrier Dec 19, 2020
@github-actions

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Jan 19, 2021

@serverwentdown serverwentdown left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, erroneous extra comma in code comment.

@eamanu eamanu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about a new commit for only for this change.

We can take in advantage some other bugs to fix this.

Also @cpriyank don't forget sign the CLA.

Comment thread Lib/threading.py Outdated
@ambv

ambv commented Sep 29, 2021

Copy link
Copy Markdown
Contributor

Closing in favor of GH-28623.

@ambv ambv closed this Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting core review skip issue skip news stale Stale PR or inactive for long period of time.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants